policyengine-us icon indicating copy to clipboard operation
policyengine-us copied to clipboard

California State Preschool Program

Open vrathi101 opened this issue 1 year ago • 1 comments

Fixes #1263

vrathi101 avatar Aug 09 '24 20:08 vrathi101

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.97%. Comparing base (f57467b) to head (b8ea87c). Report is 21 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4854      +/-   ##
==========================================
- Coverage   99.00%   98.97%   -0.03%     
==========================================
  Files        2536     2539       +3     
  Lines       36845    36931      +86     
  Branches      152      156       +4     
==========================================
+ Hits        36479    36554      +75     
- Misses        337      347      +10     
- Partials       29       30       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 15 '24 20:08 codecov[bot]

@vrathi101 we need to refactorΩ this variable as we made adjustments to the way we compute the benefits vars.

PavelMakarchuk avatar Aug 17 '24 13:08 PavelMakarchuk

@PavelMakarchuk fixed, these programs do not change the household benefits parameter date so I just added to existing list

vrathi101 avatar Aug 17 '24 14:08 vrathi101

Sorry if I wasn't clear - could you help me understand the purpose of this PR? It doesn't incorporate the rules in #1263, and at this point only defines the California programs as identical to the respective federal programs.

MaxGhenis avatar Aug 18 '24 16:08 MaxGhenis

Sorry if I wasn't clear - could you help me understand the purpose of this PR? It doesn't incorporate the rules in #1263, and at this point only defines the California programs as identical to the respective federal programs.

sorry for the confusion, I think I should instead add head_start and early_head_start to household_benefits because I realized half way through the Pr that CA programs have same eligibility criteria as the federal programs

vrathi101 avatar Aug 18 '24 16:08 vrathi101