pokeapi icon indicating copy to clipboard operation
pokeapi copied to clipboard

Moltres + Other Gen 4 Legendaries Missing Gen 4/6 Encounter Data

Open evinjaff opened this issue 3 years ago • 1 comments

Hi, so I checked the issues, and noticed that about 14 months ago, PR 583 was supposed to add new data for Moltres. I noticed while building a pokedex tracker with the API for a school project that there is encounter data for Articuno and Zapdos but that Moltres is still missing data (presumably because Moltres is found in a new location than the Kanto Games - Mt. Silver ). Additionally, there is no roaming encounter data for Pokemon Platinum. I'm not super up to date on my Gen 6 data, but I also think there is an X and Y encounter that may or may not be roaming/static? Bulbapedia says that you can get a static encounter after failing to catch it roaming.

EDIT: I also just realized that there isn't any Sinjoh Ruins Data for Dialga, Palkia, and Giratina. Has there been a consensus of if that should be allowed in? It is technically a special distribution encounter so I can see why that might not be allowed.

Is this expected behavior? If not, I'd be happy to make a PR with the appropriate changes when I have a free minute.

Bulbapedia Entry to confirm this

Steps to Reproduce:

  1. GET request of json for https://pokeapi.co/api/v2/pokemon/146/encounters
[{"location_area":{"name":"kanto-victory-road-2-2f","url":"https://pokeapi.co/api/v2/location-area/332/"},"version_details":[{"encounter_details":[{"chance":100,"condition_values":[],"max_level":50,"method":{"name":"only-one","url":"https://pokeapi.co/api/v2/encounter-method/20/"},"min_level":50}],"max_chance":100,"version":{"name":"red","url":"https://pokeapi.co/api/v2/version/1/"}},{"encounter_details":[{"chance":100,"condition_values":[],"max_level":50,"method":{"name":"only-one","url":"https://pokeapi.co/api/v2/encounter-method/20/"},"min_level":50}],"max_chance":100,"version":{"name":"blue","url":"https://pokeapi.co/api/v2/version/2/"}},{"encounter_details":[{"chance":100,"condition_values":[],"max_level":50,"method":{"name":"only-one","url":"https://pokeapi.co/api/v2/encounter-method/20/"},"min_level":50}],"max_chance":100,"version":{"name":"yellow","url":"https://pokeapi.co/api/v2/version/3/"}},{"encounter_details":[{"chance":100,"condition_values":[],"max_level":50,"method":{"name":"only-one","url":"https://pokeapi.co/api/v2/encounter-method/20/"},"min_level":50}],"max_chance":100,"version":{"name":"firered","url":"https://pokeapi.co/api/v2/version/10/"}},{"encounter_details":[{"chance":100,"condition_values":[],"max_level":50,"method":{"name":"only-one","url":"https://pokeapi.co/api/v2/encounter-method/20/"},"min_level":50}],"max_chance":100,"version":{"name":"leafgreen","url":"https://pokeapi.co/api/v2/version/11/"}}]}]
  1. See that there is no encounter data for anything other than the Kanto Games (R/B/Y & FR/LG)

Expected Behavior: An additional Array entry with data for Mount Silver encounter data as well as a sinnoh-roaming entry for Pokemon Platinum.

evinjaff avatar May 02 '22 18:05 evinjaff

#738 adds this missing data and more, all legendaries and event pokemon are added up to gen 4 inclusive

SimplyBLGDev avatar Jul 27 '22 22:07 SimplyBLGDev

Nice! I totally forgot that I submitted this issue, glad the data got updated

evinjaff avatar Oct 03 '22 21:10 evinjaff