pokeapi icon indicating copy to clipboard operation
pokeapi copied to clipboard

Implemented suggest change of renaming locations.csv id=768 to malie-city--proper

Open O-Tahmas opened this issue 1 year ago • 3 comments

This PR addresses the issue of duplicate location entries in locations.csv for malie-city. Currently, both id=768 and id=1045 are listed as malie-city. To resolve this, id=768 has been renamed to malie-city--proper.

This change ensures that all (region_id, identifier) combinations in locations.csv are unique, maintaining data integrity and clarity for location entries.

O-Tahmas avatar May 28 '24 14:05 O-Tahmas

Hi! Why the double --?

Naramsim avatar Jun 02 '24 09:06 Naramsim

Hi! Why the double --?

Hey! I just copied & pasted from the issue thread to be safe :) https://github.com/PokeAPI/pokeapi/issues/1097

O-Tahmas avatar Jun 02 '24 09:06 O-Tahmas

Yeah, but that's not a valid reason 😂😂.

I'd say we go with the single one. Or maybe you can tag the guy who replied to you on the other issues

Naramsim avatar Jun 03 '24 13:06 Naramsim

Hi @O-Tahmas , can you remove one dash so we can merge?

Naramsim avatar Jul 12 '24 06:07 Naramsim

So sorry! Thought I pushed the change.

O-Tahmas avatar Jul 14 '24 14:07 O-Tahmas

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

pokeapi-machine-user avatar Jul 16 '24 22:07 pokeapi-machine-user

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

pokeapi-machine-user avatar Jul 16 '24 23:07 pokeapi-machine-user