Enable USE_UMFPACK in surface module on macOS CI

Open cybaol opened this issue 1 year ago • 1 comments

Jul 08 '24 09:07 cybaol

Since it only touches 3. party On nurbs, I think its fine to merge (our CI's is green) - what do you thing @mvieth ? But I won't be able to review in detail.

@cybaol Do you have any benchmarks for how much its improved?

Aug 27 '24 19:08 larshg

@cybaol Do you have any benchmarks for how much its improved?

No, I just found USE_UMFPACK is false in surface/on_nurbs(see https://github.com/PointCloudLibrary/pcl/blob/master/surface/src/on_nurbs/on_nurbs.cmake#L50). And didn't bother to build it in any of the other CIs. So I decided to test it on macOS CI.

But, I've found that MacOS's stricter code checking has led to a lot of compilation errors in third-party opennurbs library. So I fixed it.

Oct 24 '24 10:10 cybaol