eos_plugin_for_unity icon indicating copy to clipboard operation
eos_plugin_for_unity copied to clipboard

tests(networking): Test for TaskNetworkTimeoutSeconds

Open WispyMouse opened this issue 1 year ago • 2 comments

This adds a test for the TaskNetworkTimeoutSeconds.

I expect this to be controversial and in need of discussion!

  • Made the login method of EOSTestBase static, so non-inheritors can call it
  • The test class we made tears down and sets up the entire EOS SDK each time it is run, for each test
  • In order to get the EOSConfig up to where it needs to be, added parameters that override the test

I would really like suggestions on how to better manage the EOSConfig needing customization while creating a new platform. It's definitely not hitting all of the places. Maybe there's something we could add to the Config base class that lets us register an overriding EOSConfig to use?

WispyMouse avatar Jul 25 '24 21:07 WispyMouse

Noting here: The plan is to hold off on merging this over until after the rework and retooling on tests has been made. This will be a testbed for iterating on the design of tests.

WispyMouse avatar Jul 29 '24 21:07 WispyMouse

Just to remind myself: One of the things to change was the way that custom test config files can be passed to the initialization.

WispyMouse avatar Aug 07 '24 21:08 WispyMouse

While the custom config might become available at some point, I think it makes sense to close this PR for now. We'll revisit the ideas present here when the time is more appropriate.

WispyMouse avatar Nov 14 '24 19:11 WispyMouse