PlasmaPy
[WIP] Electron config class
Beginnings of classes for subshells, electron configurations, term symbols, energy levels, and transitions (each one building off of the former).
PR is not ready yet, just doing this for easier tracking/discussing.
Addresses #4
Hello @lemmatum! Thanks for updating your pull request.
- In the file
SpectroscoPyx/atomic/electronConfiguration.py, following are the PEP8 issues :
Line 80:54: W291 trailing whitespace Line 89:1: W293 blank line contains whitespace Line 94:72: W291 trailing whitespace Line 119:1: E265 block comment should start with '# ' Line 149:16: E261 at least two spaces before inline comment Line 150:16: E261 at least two spaces before inline comment Line 151:16: E261 at least two spaces before inline comment Line 152:16: E261 at least two spaces before inline comment Line 185:1: E265 block comment should start with '# ' Line 186:1: E302 expected 2 blank lines, found 1 Line 215:5: E301 expected 1 blank line, found 0 Line 221:9: E743 ambiguous function definition 'l' Line 232:5: E301 expected 1 blank line, found 0 Line 244:5: E301 expected 1 blank line, found 0 Line 256:5: E301 expected 1 blank line, found 0 Line 279:19: E711 comparison to None should be 'if cond is None:' Line 282:5: E301 expected 1 blank line, found 0 Line 288:1: W293 blank line contains whitespace Line 290:1: W293 blank line contains whitespace Line 292:25: W291 trailing whitespace Line 303:1: E265 block comment should start with '# ' Line 317:59: W291 trailing whitespace Line 322:1: W293 blank line contains whitespace Line 324:1: W293 blank line contains whitespace Line 325:1: W293 blank line contains whitespace Line 326:9: E303 too many blank lines (2) Line 328:1: W293 blank line contains whitespace Line 331:1: W293 blank line contains whitespace Line 333:1: W293 blank line contains whitespace Line 336:27: W291 trailing whitespace Line 337:1: W293 blank line contains whitespace Line 338:72: W291 trailing whitespace Line 341:5: E301 expected 1 blank line, found 0 Line 352:5: E301 expected 1 blank line, found 0 Line 361:5: E301 expected 1 blank line, found 0 Line 375:1: W293 blank line contains whitespace Line 377:1: W293 blank line contains whitespace Line 379:1: W293 blank line contains whitespace Line 381:5: E301 expected 1 blank line, found 0 Line 387:5: E301 expected 1 blank line, found 0 Line 393:5: E301 expected 1 blank line, found 0 Line 400:19: W291 trailing whitespace Line 408:1: W293 blank line contains whitespace Line 411:1: E265 block comment should start with '# ' Line 411:1: E303 too many blank lines (3) Line 413:1: E302 expected 2 blank lines, found 3 Line 432:1: E265 block comment should start with '# ' Line 457:5: E301 expected 1 blank line, found 0 Line 462:5: E301 expected 1 blank line, found 0
- In the file
SpectroscoPyx/atomic/tests/test_electronConfiguration.py, following are the PEP8 issues :
Line 10:19: W292 no newline at end of file
