hl2sb-src icon indicating copy to clipboard operation
hl2sb-src copied to clipboard

SetObserverTarget function missing

Open Dim1xs opened this issue 1 year ago • 11 comments

Lua has everything for enabling Observer mode for player, but it dont has a function SetObserverTarget. That's kinda bad.

Dim1xs avatar Jun 02 '24 21:06 Dim1xs

@GuestSneezeOSDev of course

Dim1xs avatar Sep 13 '24 12:09 Dim1xs

@Dim1xs @GuestSneezeOSDev That's odd that we never implemented this. Looks like it's from the client-side CBasePlayer class?

andrewmcwatters avatar Sep 16 '24 18:09 andrewmcwatters

@andrewmcwatters I think you could, i found that function in player.h and in c_baseplayer.h, and i found also that SetBodygroup for Server-side of Lua CBaseAnimating is missing too.

Dim1xs avatar Sep 17 '24 12:09 Dim1xs

@GuestSneezeOSDev nope, current source code doesn't compiles for me.

Dim1xs avatar Sep 17 '24 12:09 Dim1xs

@GuestSneezeOSDev I'd like to, too, but there's a number of minutiae that need to be addressed. It's on my backlog. That codebase evolved from 2006 -> 2007 -> 2013, so there's some large scale manual diff review that needs to go on.

Luckily, we mostly wrapped our diffs around HL2SB #ifdefs to make these ports overtime easy to handle, but it's still a large chore. And we never really adopted VPC, having a single target we were allowed to publish to since we weren't licensees. We simply patched the built project files and pushed them up over the years.

andrewmcwatters avatar Sep 17 '24 20:09 andrewmcwatters

@GuestSneezeOSDev In theory, you should be able to check out a fresh copy of 2013, literally drop hl2sb-src on top of it, and see what changes there are wrapped in HL2SB ifdefs.

andrewmcwatters avatar Sep 17 '24 20:09 andrewmcwatters

@GuestSneezeOSDev I don't think too much really changes between them. It's really the engine itself, iirc. I'm not sure how much of the newer engine features we expose to Lua between the engine branches.

andrewmcwatters avatar Sep 18 '24 17:09 andrewmcwatters