Cubyz icon indicating copy to clipboard operation
Cubyz copied to clipboard

Item drop shadow is not aligned to the pixel grid

Open careeoki opened this issue 1 year ago • 11 comments

image Creates floating subpixel artifacts on the north-east and south-west sides, which looks especially messy at normal scale image On dark items, it just looks like a big blob. Giving the shadow some transparency would fix this

careeoki avatar May 20 '24 03:05 careeoki

I intentionally made the offset of the shadow less than one pixel because I didn't like how it looked when it is aligned. The shadow is cut off by the texture in an awkward way, it's especially bad on something like the diamond, where it looks like someone just drew a straight line of black pixels on the textures. Screenshot at 2024-05-20 10-13-54

IntegratedQuantum avatar May 20 '24 08:05 IntegratedQuantum

As for weaker shadows I think you'll always end up messing up the contrast for some blocks, like here the stone and ore blocks have poor contrast. If I make the shadow stronger than this, then the pine log has poor contrast. Screenshot at 2024-05-20 10-30-40

IntegratedQuantum avatar May 20 '24 08:05 IntegratedQuantum

Yeah, the opacity doesn't help as much as I would have hoped. I honestly think the best solution is just to not have a drop shadow at all. Item textures already/will have shaded outlines, which i think achieves the same effect. The lighting could be made more intense on blocks, to replace the "3D" effect the drop shadow provided image

careeoki avatar May 20 '24 17:05 careeoki

Currently the contrast of the item drops is currently tied to the contrast of blocks in the world.

Maybe this is a good time to decide whether it makes sense to increase the contrast in the world as well?

IntegratedQuantum avatar May 20 '24 18:05 IntegratedQuantum

Maybe. I would have to see what that looks like. Regardless, they should have higher contrast in the inventory.

careeoki avatar May 20 '24 18:05 careeoki

Current: Screenshot at 2024-05-20 20-07-49 More: Screenshot at 2024-05-20 20-08-19 Even more: Screenshot at 2024-05-20 20-09-12 One thing that seems to happen is that the world gets darker the more contrast there is.

IntegratedQuantum avatar May 20 '24 18:05 IntegratedQuantum

I'll have to think on this. I do think having a bit more contrast could look better, just not sure how much. You should post these to discord to see what others think.

careeoki avatar May 20 '24 18:05 careeoki

I think image 2 looks best. Or maybe somewhere in between current and image 2

careeoki avatar May 21 '24 17:05 careeoki

Another point against drop shadow: it doesn't work with translucent blocks. image

careeoki avatar May 22 '24 00:05 careeoki

I added the contrast, but I'm still hesitant to remove the shadows. Without them it looks kind of flat in my opinion: Screenshot at 2024-05-22 13-51-50

As for translucent blocks, they are a different issue. It might be worth considering to draw them with transparency (which would allow for colored shadows).

IntegratedQuantum avatar May 22 '24 11:05 IntegratedQuantum

It would look better with my updated textures. Let's wait and see until then.

careeoki avatar May 22 '24 23:05 careeoki