Jungle
This proposal contains a proposal of jungle improvements. Additionally it contains monstera plant created @careeoki which is heavily used in new jungle.
I would appreciate #1793 for this so we can properly mix monsteras, ferns, grass and flowers 😄
Trees found in this biome have branch based roots, which are susceptible to known branch issues:
Should I remove those roots? This problem is less visible among leaves.
I have segmented the large sapele trees and added decoration to them:
I have also removed branch roots from some of them, they were causing to much trouble. However, we need more complex solution to this problem, some way of forcing block updates in generation for some blocks, because junctions of branches look even worse than branches replacing full wood blocks.
The trees look amazing. The giant ones are very treehouse worthy. Some subbiomes would be nice, like a sparse jungle or clearing. I do have some minor nitpicks I'm going to make a PR for in a moment.
There is some work to left:
- [ ] ~~split
ancientsapeletree into segments~~ - [x] add child blocks for decoration on
ancientsapeletree - [ ] ~~add 2nd variant of
mediumsapeletree~~ - [ ] ~~add 2 more
bushvariants~~ - [ ] ~~add 2 variants of
largekhaya_ivorensis~~ - [ ] ~~add 2nd variant of
smallkhaya_ivorensis~~ - [ ] ~~add
socratea exorrhiza- a walking palm tree, a very unique looking plant. Although its not mahogany, for now we can just add them with mahogany wood and decide to change it to palm wood if we decide to add it.~~ Postponed.
I don't think splitting khaya_ivorensis models make sense, considering they easily disappear in the jungle and they have a very strange shape (they don't have a simple, long, straight stem). There is already a lot of variation elsewhere and the jungle is mostly made out of leaf blocks anyway, individual trees blend easily.
I won't include what Carrie said in this list, so to not duplicate it, but it very much applies. I would appreciate if someone could have a look at subbiomes, because honestly I was only interested in making trees :3
I can do some subbiomes.
@Argmaster I made a PR for subbiomes
I think I am happy with the outcome and I will give up on further changes in the trees unless requested as necessary. Biome variants @careeoki made are super cool and they improved the jungle a lot. Monstera, also made by @careeoki, turned out to be an absolute game changer when it comes to making jungle feel like an actual jungle.
I still want to add socratea exorrhiza - a walking palm tree, but I will do that later perhaps, as I am simply tired of tweaking that jungle.
Additionally what would be good to add as soon as particles are ready to be used in prod is #2115 to make the jungle feel more alive as it is one of the most alive biomes you can think of.
Addressing @ikabod-kee concerns with wood collection, I have added quite a few fallen trees, additionally 2x2 trees are very very easy to cut down as you can make circle staircase through them and walk on the branches. If we allowed climbing the ivy it would improve even further. Short trees are fairly simple to cut down as they are in your reach all the time, while tall trees are tall trees and are awkward to cut down. Well, typical, can't do much about the last.
I did some testing how it would feel if leaves had no hitboxes and in my opinion this is totally viable with addition of branches. It is very cool that you can climb to the top of the tree through branches. I encourage you to try that, its a lot of fun. I won't force that change in this PR but I would like to open (or re-open) this discussion.
(screenshots were made on version 0.0.0 thus old fern)
Thank you for including fallen logs for wood collection :) It should help players out a lot
You should totally make a seperare PR for no-collision leaves. Is it possible right now for leafy branches to only have collison on the branch parts?
Is it possible right now for leafy branches to only have collison on the branch parts?
I couldn't get this to work, it will probably be possible with #1821 though.
Hm, that's strange, I haven't seen single one of those, when I was flying around. Can you quickly check if they are taller than 32 blocks or something?
They are not cut off at chunk borders, so that can't be it.
Ok, top model is definitely too small, I must have done something to break it
Now they are cut at chunk borders:
Cool. I guess tallest extender goes bye bye I need to do math tho to be sure its >32 blocks
Is it perhaps because of the roots?
Perhaps it is. Although It seems like I am exceeding the limit by quite a bit. Basically all the height variation goes out the window :C I think I will need to make a second top blueprint, that is only one layer of leaves to have a variant with longer extenders.
The roots are irrevelant, what matters is the distance from the origin block.
I noticed during #2176 that the upper limit is acutally just ±16 not 32. I guess it would make sense to just increase the limit at this point.
Please fix conflicts
Ok, I added 2nd variant of ancient sapele tree top and changed configs so previous top is only used with shorter extenders while new top is used with longer one, I didn't notice any trees getting cut off after that.
Also, you could try using basalt as a stone here!
I doubt these are supposed to look like this?
Umm thats interesting. Did we remove any cobble-like blocks recently? It seems id got reallocated to different block :C
I can't think of any removals between when you added these and now.
@Argmaster Did a PR based on @ikabod-kee 's requests: https://github.com/Argmaster/Cubyz/pull/19
should this be closed then? i am curious why the changes weren't just commited to this pr
should this be closed then? i am curious why the changes weren't just commited to this pr
Permissions.
Ruins are in fact broken, so I remade them. I accept no request for more variety etc. It is what it is, I will add more in the future.