Piwigo-Android icon indicating copy to clipboard operation
Piwigo-Android copied to clipboard

Extend photo upload / edit possibilities

Open ramack opened this issue 7 years ago • 5 comments

Allow to upload

  • [x] via FAB "+" to directly select file to upload into the current album (see #104)
  • [ ] of modifiable size and quality
  • [ ] tags, EXIF metadata,
  • [ ] with or without GPS metadata,
  • [x] upload in background one file after the other (see #118)
  • [ ] show a progress bar in the notification

ramack avatar Sep 25 '18 19:09 ramack

@EddyLB after selecting the plus button iphone se 4-inch -image2

the iOS app shows the dialog iphone se 4-inch -image5 What happens if we select "Upload Images" there? Does it directly open the media storage to choose and how (if at all) do you allow to modify Image Title, Tags, Description access rights, options for upload (resize?)

I personally would prefer to directly select files for uploading to not "waste" user clicks. The options to create a sub-album, make the current album the default start album and "select" I would rather put into a menu on the upper right part of the action bar (where in iOS the "select" is) - maybe the add sub-album could be also reachable via long-click on the "+". What do you think?

ramack avatar Nov 09 '18 23:11 ramack

Hi @ramack After tapping "Upload Images", the app presents the list of local and shared albums (see below). These albums are managed in the Apple Photos app. I guess this is similar on Android. localalbums

After selecting one of these albums, the app presents the images it contains. The user can then slide-select images to upload: selectimages

Today, the user can select a sort option:

  • Sort images starting with the newest
  • Sort images starting with the oldest
  • Suggest only images not already uploaded (the app compares filenames)

EddyLB avatar Dec 16 '18 09:12 EddyLB

@ramack , as for menus the app is organised as described below. The main idea is that each corner of the screen brings a list of tools related to only one global functionality:

  • Top/left - Navigation tools: Prefs button at root level (or default album level) and back button to go up in the hierarchy of albums
  • Top/right - Selection tools: Only a "Select" images action today ("Cancel" when selection mode active). In a longer term, this will be a menu proposing filters and sort tools to ease the selection. A magnifier lens will also be added to search images/albums as on the web interface.
  • Bottom/right - Add content tools: [+] button to create sub-albums, to upload images in the current album or sub-albums, to select the current album as default album. @plegall has recently suggested to add a "Camera" button for taking pictures that will be uploaded right away in the current album. A [Home] button is displayed on the left of this [+] button to quickly return to the default album when the current album is not the default one.
  • Bottom/left - Bckg tasks management tools: Nothing today but the plan is to display a circular button containing the number of images that remains to upload with some animation showing the progress of the current upload task. A tap on it will display the list of images to be uploaded with tools to cancel, etc.

EddyLB avatar Dec 16 '18 10:12 EddyLB

Thanks for sharing these concepts. This is already quite a lot of stuff, I would like to have the "background" stuff not in the Bottom/left corner, but in a notification (which we anyhow need in Android to allow background task). Bottom right for adding (and maybe other dynamic / context sensitive most needed functions is prefect, but we should not have too many of those "floating action buttons".

Do you have an idea how to allow the user to smoothly change title, description, tags etc. for uploaded photos?

Edit: also for example creating new subalbums at the given level seems to be an interesting option. So maybe a long-click on the FAB should expand a set of FABs for different things like

  • "Add picture(s) with an edit dialog for each of them to modify all details"
  • "Add picture(s) without details editing"
  • "Add subalbum"
  • "Add photo from camera"

ramack avatar Dec 16 '18 12:12 ramack

Hi @ramack I agree that we should not have too many "floating buttons". In addition to a badge showing the number of photos remaining to be uploaded (which cannot be used to open a view with iOS), the app may temporarily add a command "Transfers" in the Upload section allowing to reopen the list of images in the queue, below 'Upload Images", "Create Album" and "Set as Default Album".

As for editing images before uploading them, the app actually presents a list of images to be uploaded (which were selected by the user). The user can edit each photo individually after tapping on it. He can also remove images from the list if he changes his mind (swipe left action). After pressing "Upload", images are moved to the section "Images that are being uploaded".

upload

Of course, the user can later edit any image he wants. He gets the same "Image Details" view (which needs to be improved, for sure…): edit

EddyLB avatar Dec 29 '18 18:12 EddyLB