piston_collada icon indicating copy to clipboard operation
piston_collada copied to clipboard

Fix for blender 2.90.1 COLLADA exporter

Open bmatthieu3 opened this issue 5 years ago • 4 comments

It seems the COLLADA exporter from the new version of blender (2.90.1) adds a wrapper node named animation between library_animations and the list of bone animations. I am writing a library on top of this very good parser and this fix allowed me to open collada files from blender 2.90.1. It is still not possible to export multiple animations inside one DAE file but that is another problem coming from the blender collada exporter I think. The library is https://github.com/bmatthieu3/rib if you want to check.

Maybe this fix break importations from the previous blender versions

bmatthieu3 avatar Nov 23 '20 19:11 bmatthieu3

@bmatthieu3 can you fix the test test_get_animations? Run cargo test.

bvssvni avatar Feb 13 '21 03:02 bvssvni

@bmatthieu3 is this still an issue?

bvssvni avatar Sep 04 '21 21:09 bvssvni

Hi, I think this was due to a (maybe, this is what I deduced) from a breaking change in the way blender 2.90.1 serialize to collada comparatively to its previous version. Maybe a fix would be to parse the normal way and if its fails (exception) then try the "2.90.1" way.

Le sam. 4 sept. 2021 à 23:15, Sven Nilsen @.***> a écrit :

@bmatthieu3 https://github.com/bmatthieu3 is this still an issue?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PistonDevelopers/piston_collada/pull/43#issuecomment-913042177, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVE3IDWOYEQEPAYARNKXQTUAKD77ANCNFSM4T74I2NA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

bmatthieu3 avatar Sep 05 '21 06:09 bmatthieu3

@bmatthieu3 Yeah, that might work. Do you want to update the PR?

bvssvni avatar Sep 05 '21 07:09 bvssvni