conrod icon indicating copy to clipboard operation
conrod copied to clipboard
verified publisher icon PistonDevelopers

Update `pistoncore-glutin_window` in `conrod_piston`

Open adumbidiot opened this issue 5 years ago • 4 comments

This PR updates piston2d-graphics to 0.39.x and piston_window to 0.113.x, which bumps pistoncore-glutin_window from 0.66.0 to 0.67.2. I did this to fix https://github.com/PistonDevelopers/glutin_window/issues/187 which occurs while trying to use conrod_piston.

adumbidiot avatar Jan 05 '21 02:01 adumbidiot

Hi, thanks for the PR. Unfortunately I am not able to verify that this is working. When I try to run the all_piston_window on my Fedora KDE system it is panicking with the same error as https://github.com/rust-windowing/winit/issues/636 ("Failed to open input method").

@bvssvni Ping, can you help with this?

P.S. The failing checks are not caused by the changes in this PR, but is due to a breaking change in vk-sys (https://github.com/vulkano-rs/vulkano/issues/1464).

alvinhochun avatar Jan 11 '21 12:01 alvinhochun

@alvinhochun I've tested these changes and they work.

bvssvni avatar Feb 13 '21 03:02 bvssvni

I've been playing with this a bit more and I'm getting problems with logical vs physical pixels. I'll try to fix that when I get some time.

adumbidiot avatar Feb 13 '21 06:02 adumbidiot

@alvinhochun I think this works now if pistoncore-glutin_window = 0.68.2. Would you mind testing it again?

adumbidiot avatar Mar 19 '21 01:03 adumbidiot