#983 - Infusionsoft Actions & Sources

[GTFalcao]

New Actions

• Create Invoice (create payment)
• Create Order Item (add product to invoice)
• Get Company
• Get Contact

New Sources

• New Appointment
• New Invoice
• New Order
• New Payment

Closes #983

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
pipedream-docs	✅ Ready (Inspect)	Visit Preview	Sep 1, 2022 at 9:13PM (UTC)
pipedream-docs-redirect-do-not-edit	✅ Ready (Inspect)	Visit Preview	Sep 1, 2022 at 9:13PM (UTC)

[dylburger]

Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:

• [ ] Create components to address specific use cases whenever possible
• [ ] Component keys should follow the format app_name_slug-slugified-component-name
• [ ] Components should follow the standard directory structure
• [ ] Prefer Node.js client libraries to REST APIs
• [ ] When making API requests, handle pagination to ensure all data / events are processed
• [ ] Use secret props to capture sensitive data
• [ ] Props and methods should be defined in app files whenever possible
• [ ] Document methods with JS Docs
• [ ] Use optional props whenever possible, and set a default value where you can
• [ ] Use async options to accept user input wherever possible
• [ ] Create subscription webhooks sources (vs polling sources) whenever possible
• [ ] Always emit a summary with events
• [ ] Use a built-in deduping strategy wherever possible
• [ ] When building webhook sources, follow these best practices
• [ ] When building polling sources, follow these best practices

[GTFalcao]

Thanks for your very helpful review @jcortes ! I've addressed all the notes you left and moved this back to the review queue

[DilanAthukorala]

@GTFalcao Following Issues / improvements are observed

1. for create payment action, payment amount and payment method props should be mandatory but currently it has been defined as optional.

2. No events are emitted for New Appointment source after creating appointments

[GTFalcao]

I've changed the payment method and amount props to required. They were initially set to optional as the API does not label them as required, but I can see why they should be.

As for the 'New Appointment' source, it seems Keap's app/interface is not triggering the event correctly, as when I created the appointment via their API, it triggered as expected. Attaching screenshots below.

I reported this bug to Keap and, for the time being, removed the 'New Appointment' source from this pull request, so that the other components can be released instead of being blocked by this issue.

[DilanAthukorala]

Verification completed and this is ready for release.