PipedreamHQ
[FEATURE] Share components between GitLab --> Gitlab (Developer App)
We've added a new GitLab (Developer App) that enables users who are using self-hosted GitLab to be able to connect using their own application.
Can the components that are currently available within GitLab be shared with the new GitLab (Developer App)?
Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.
Please check the test report below for more information https://vunguyenhung.notion.site/FEATURE-Share-components-between-GitLab-Gitlab-Developer-App-65c2bb80f69448b398af28f496d58006
@vunguyenhung the Project ID prop lists user's owned projects instead of listing all projects visible to the user. If this should be changed, we should change it in the original Gitlab app. I was also able to list several projects on my account using the latter endpoint, but had zero returned using the former.
I fixed the error preventing sources from being used. I also double checked that all propDefinitions are being correctly imported from the original Gitlab app and assigned to the new one, so the code being executed is exactly the same (as it should be, since the API is the same)
Hey @GTFalcao, for the Project ID prop, I have 3 projects and I can fetch them using Gitlab API in my code step
But the Project ID prop still show empty result
From end user perspective, I expect that the Project ID prop should have 3 options (matching with my 3 projects)
Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.
Please check the test report below for more information https://vunguyenhung.notion.site/FEATURE-Share-components-between-GitLab-Gitlab-Developer-App-65c2bb80f69448b398af28f496d58006
I've adjusted the List Projects behavior. Note that since the behavior is the same in both apps, I've adjusted the original Gitlab app to match the desired behavior, so all Gitlab components are now being updated as well.
The 403 issue when listing epics also happens in the existing Gitlab app, unrelated to the component migration - the documentation mentions the Epics API as a premium+ feature, unavailable to the free tier.
@vunguyenhung just remembered, perhaps the Epic ID prop's description should mention this premium tier limitation?
Yeah that makes sense @GTFalcao! We should mention it it the prop description
Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.
Please check the test report below for more information https://vunguyenhung.notion.site/FEATURE-Share-components-between-GitLab-Gitlab-Developer-App-65c2bb80f69448b398af28f496d58006
Hey @vunguyenhung , thanks for the very thorough testing, this is an overview of all the components that had issues in your report:
- Create Epic
- ✅ Marked Parent ID as optional
- ✅ Fixed the Label prop
- ❓ The Parent ID prop seems to be sent properly, this might need some business rule understanding to figure out
- ✅ Update Epic: labels prop was fixed, I could not reproduce 'hang at loading' issue, could it be intermittent?
- ✅ Update Issue: fixed labels prop not being sent in request
- ❓ New Issue: I could not reproduce the error, I'm getting events emitted normally and no errors logged - could it happen only in some scenarios? (the expected schema seems to be correct, too)
- ❓ New Merge Request: same as above
- ✅ New Mention: this happened due to the username prop being optional but the source used it to filter mentions. I changed the prop to required
- ✅ New Milestone: fixed the bug
- ✅ New Review Request: adjusted behavior to check 'reviewers' instead of 'assignees', and received events as expected, I could not reproduce the console error, might be situational?
Since all of these issues happen in the current (live) Gitlab components, I think any pending ones that need further investigation or business rule understanding, should be moved to a new issue so we can release all the fixes and improvements already done (as well as adding the components to the Gitlab Developer App).
Let me know if this makes sense.
Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.
Please check the test report below for more information https://vunguyenhung.notion.site/FEATURE-Share-components-between-GitLab-Gitlab-Developer-App-65c2bb80f69448b398af28f496d58006
Hey @GTFalcao, thanks for fixing the bugs. I've tested again and there're some issues remaining. Thank you for your effort
It seems "Group ID" and "Group Path" were mixed, which was causing the issues in the group labels and other props that depended on the group id (but received a group path). I also added an error treatment for the merge request sources.
Hi everyone, all test cases are passed! Ready for release!
Test report https://vunguyenhung.notion.site/FEATURE-Share-components-between-GitLab-Gitlab-Developer-App-65c2bb80f69448b398af28f496d58006
Big thank you @GTFalcao for the close attention to detail on these component, as well as to @vunguyenhung for the thorough testing here - really happy to see the usability improvements on these GitLab components!