ci icon indicating copy to clipboard operation
ci copied to clipboard

feat: stop push docker for rc

Open jayl1e opened this issue 1 year ago • 4 comments

Why:

  • new RC build will publish docker for QA

jayl1e avatar Mar 15 '24 06:03 jayl1e

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from lijie0123, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Mar 15 '24 06:03 ti-chi-bot[bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request, the key changes are as follows:

  • The code has been updated to stop pushing Docker for RC.
  • The condition for publishing the community image and enterprise image has also been updated based on the release tag.

The potential problem with this pull request is that it could break the current build pipeline and also affect the deployment process. The current changes will prevent the pushing of Docker for RC, which could negatively impact the deployment process.

One possible suggestion for fixing this issue is to add a new flag that can be used to switch between pushing Docker for RC and not pushing it. This flag can be set during the build process and will allow for greater flexibility in the deployment process.

Additionally, it would be helpful to add more information to the pull request description, such as the reason for stopping the push of Docker for RC. This will help to provide greater context for the changes being made and make it easier for other developers to understand the impact of the changes.

ti-chi-bot[bot] avatar Mar 15 '24 06:03 ti-chi-bot[bot]

/hold

jayl1e avatar Mar 18 '24 10:03 jayl1e

/hold

keep it when we require it.

wuhuizuo avatar Mar 21 '24 11:03 wuhuizuo