photonvision icon indicating copy to clipboard operation
photonvision copied to clipboard

Update backend to Java 17

Open srimanachanta opened this issue 2 years ago • 6 comments

I don't know if we should ship this so close to the new season but opening this up for conversation. Also needs the pi image gen to be updated from jdk-11 to jdk-17.

srimanachanta avatar Dec 24 '23 16:12 srimanachanta

Is wpilib all in on Java 17? If so, the pi image has been updated so I'm good to ship it

mcm001 avatar Dec 25 '23 00:12 mcm001

Looks like WPILib still has sourceCompatibility=11 all over? So let's hold off

mcm001 avatar Dec 25 '23 00:12 mcm001

I'm actually OK if we only touch photon-core and don't change targeting or lib

mcm001 avatar Dec 25 '23 15:12 mcm001

I'm actually OK if we only touch photon-core and don't change targeting or lib

That was my intention, the version of photon-core and server are irrelevant as they only depend on the installed JDK version, not the rio, hence I left photon-lib and photon-targeting unchanged when we very well could bump those as well.

srimanachanta avatar Dec 25 '23 17:12 srimanachanta

Let's hold off here until we get all the other PRs in just so we don't go creating extra merge conflicts

mcm001 avatar Dec 28 '23 05:12 mcm001

Looks like this has a bunch of merge conflicts now lol

mcm001 avatar May 09 '24 17:05 mcm001