scripts icon indicating copy to clipboard operation
scripts copied to clipboard

Add Adobe Photoshop

Open ImperatorS79 opened this issue 6 years ago • 9 comments

Description

Following of #908 . Needs #1121 and #1074.

What works

Begin of installation

What was not tested

End of installtion, the app itself

Test

  • Operating system (and linux kernel version): gitpod
  • Hardware (GPU/CPU): gitpod

Ready for review

  • [ ] Script tested as a regular phoenicis user and working (if you have a problem -> create as draft and ask for help).
  • [x] json-align and eslint run according to the documentation.
  • [x] Codacy and travis checked.

ImperatorS79 avatar Sep 10 '19 14:09 ImperatorS79

@madoar Despite latest change to Zip extraction, I cannot extract the 1.7 GB archive in my vm using phoenicis (2GB ram):

[INFO ] org.phoenicis.tools.archive.Tar (l.56) - Uncompressing /home/vmachine/.Phoenicis/containers/wineprefix/Adobe Photoshop/drive_c/archive.zip to dir /home/vmachine/.Phoenicis/containers/wineprefix/Adobe Photoshop/drive_c/Adobe Photoshop.
[ERROR] org.phoenicis.multithreading.ControlledThreadPoolExecutorService (l.64) - Java heap space
        at java.base/java.nio.file.Files.read(Files.java:3227)
        at java.base/java.nio.file.Files.readAllBytes(Files.java:3287)
        at org.phoenicis.tools.files.FileAnalyser.getMatch(FileAnalyser.java:66)
        at org.phoenicis.tools.files.FileAnalyser.getMimetype(FileAnalyser.java:83)
        at org.phoenicis.tools.archive.Extractor.uncompress(Extractor.java:59)
        at org.phoenicis.tools.archive.Extractor.uncompress(Extractor.java:45)
        at java.base/java.lang.invoke.LambdaForm$DMH/0x0000000100942840.invokeVirtual(LambdaForm$DMH)
        at java.base/java.lang.invoke.LambdaForm$MH/0x0000000100968440.invoke(LambdaForm$MH)
        at java.base/java.lang.invoke.Invokers$Holder.invokeExact_MT(Invokers$Holder)
Caused by host exception: java.lang.OutOfMemoryError: Java heap space

But ArK (KDE archive extractor) do it without any problem.

ImperatorS79 avatar Sep 13 '19 18:09 ImperatorS79

How does the archive look like? Does it contain a large file?

plata avatar Sep 16 '19 17:09 plata

It contains a 1GB sub zip file.

ImperatorS79 avatar Sep 16 '19 18:09 ImperatorS79

Can you validate if you get the same issue if the archive contains only small files?

plata avatar Sep 17 '19 16:09 plata

I need to find a 2 GB zip file with only small files... ^^

ImperatorS79 avatar Sep 17 '19 17:09 ImperatorS79

You could generate one by creating a directory, putting many small files in it and then zip it.

plata avatar Sep 19 '19 17:09 plata

We cannot merge this if we cannot validate that it's actually working.

plata avatar Oct 05 '19 09:10 plata

@ImperatorS79 what's the status here?

plata avatar Dec 28 '19 12:12 plata

Did not have the time to test it. I am really busy this year. But I will try to find some time in the current months.

ImperatorS79 avatar Dec 28 '19 16:12 ImperatorS79