Phobos icon indicating copy to clipboard operation
Phobos copied to clipboard

Refactoring PlacementPreview logic

Open Belonit opened this issue 3 years ago • 3 comments

  • General code refactoring
  • Added ability to load theater-specific shapes - #642
  • Translucent tags now should be set to 0\25\50\70 instead of 0\1\2\3
  • Renamed tags and fixed documentation errors:
    • In AudioVisual
      • BuildingPlacementPreview.DefaultTranslucentLeve ---> PlacementPreview.Translucency
      • BuildingPlacementGrid.TranslucentLevel -------------> PlacementGrid.Translucency
    • In BuildingType
      • PlacementPreview.Show ---------------------------------> PlacementPreview
      • PlacementPreview.TranslucentLevel -------------------> PlacementPreview.Translucency
    • In ra2md.ini
      • [Phobos]->ShowBuildingPlacementPreview -------------> [Phobos]->ShowPlacementPreview

Old Documentation vs New

Belonit avatar Jul 23 '22 01:07 Belonit

Nightly build for this pull request:

github-actions[bot] avatar Jul 23 '22 01:07 github-actions[bot]

There is my testing feedback: All three tags in [AudioVisual] work fine. Theater-specific shapes can be specified by PlacementPreview.Shape. Theater-specific palettes can be specified by PlacementPreview.Palette. All the rest tags work as expected.

Cpj636 avatar Jul 23 '22 13:07 Cpj636

The PlacementPreview.Shape tag does not currently support save\load. Need to fix

Belonit avatar Jul 24 '22 13:07 Belonit