Phobos icon indicating copy to clipboard operation
Phobos copied to clipboard

Dehardcode the overlay 255 limit

Open secsome opened this issue 4 years ago • 4 comments

This allows you to register and use more than 255 overlays

secsome avatar Feb 18 '22 13:02 secsome

Nightly build for this pull request:

github-actions[bot] avatar Feb 18 '22 13:02 github-actions[bot]

Attempted to test this via adding new entries to the OverlayTypes list and then using ToOverlay to place the entries on the map. This did not crash with or without Phobos or Ares. Even in Vanilla YR, I used the same extended OverlayTypes and was able to successfully build and place an OverlayType that exceeded 254=. I could use some more help in testing this or some advice in how to test this.

In order to correctly visualize the placed OverlayType, you must pan the screen on and off the newly placed OverlayType as mentioned in https://modenc.renegadeprojects.com/ToOverlay

SMxReaver avatar May 06 '22 20:05 SMxReaver

test code.txt

Attached code used for test, the Edit option for my previous comment did not want to upload the file.

SMxReaver avatar May 06 '22 20:05 SMxReaver