Phobos icon indicating copy to clipboard operation
Phobos copied to clipboard

MakeInfantry logic on BombClass resulting on `Neutral` side infantry BugFix

Open Otamaa opened this issue 4 years ago • 2 comments

close #10

  • Fix the issue when BombClass giving nullptr Techno owner resulting on Some Warhead affect no applied properly .
  • Added Ownership for BombClass explosion anim to fix problem with CreateUnit and MakeInf .

Otamaa avatar Jan 07 '22 20:01 Otamaa

Nightly build for this pull request:

github-actions[bot] avatar Jan 07 '22 20:01 github-actions[bot]

Could you explain what did you do to fix it? Looks unconventional and bit hard to read. Edited it , now it look more simple and hopefully more readable !

Otamaa avatar Jan 14 '22 15:01 Otamaa

wip-bio-infestation-2

Maybe a late review, I can confirm that "Added Ownership for BombClass explosion anim to fix problem with CreateUnit and MakeInf" works.

deathreaperz avatar Sep 16 '22 02:09 deathreaperz

Could you explain what did you do to fix it? Looks unconventional and bit hard to read.

Basically redirect the MapClass::DamageArea call to our dll and add an ownership from the BombClass itself this kind a hard way to do it because ares seems manipulating the Push stack there .

Otamaa avatar Sep 17 '22 11:09 Otamaa

Tested, appears to work. Also fixes another related issue where the vanilla code would attempt to create AnimClass even if AnimTypeClass is nullptr.

Took a liberty of fixing issue preventing the code from building as well as couple of other things and pushing it.

Starkku avatar Sep 17 '22 22:09 Starkku