Fix LimboKill not working properly

[chaserli]

Some MO devs reported that LimboKill resulted in game crashes. Yet tag AutoDeath to them wouldn't Turns out the current deletion method is overcomplicated, and so is the creation Let's try simplifying deletion first

Summary by CodeRabbit

• Refactor
  • Improved the efficiency of building-related operations in the game by optimizing property assignments and checks.

[github-actions[bot]]

Nightly build for this pull request:

• compiled-dll-d47c803de46687b230a2d7117845ddb6fa422c48.zip These artifacts will expire in 90 days and will not be available for download after that time.

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

[coderabbitai[bot]]

Walkthrough

This update refines the behavior of the LimboDelete function within FireSuperWeapon.cpp, enhancing the interaction with building objects. It transitions from direct property manipulations to employing method calls for pBuilding, streamlining the process and removing outdated checks and adjustments specific to building types.

Changes

File Path	Change Summary
src/Ext/SWType/.../FireSuperWeapon.cpp	Updated LimboDelete function: replaced property assignments with method calls on pBuilding; removed building type-specific checks and modifications.

Related issues

• Phobos-developers/Phobos#794: The changes might impact how buildings are targeted and interacted with by AI, potentially addressing issues with AI scripts related to attacking buildings and the behavior of siege units and strike teams.

🎉🐰✨
To the code we hop and bound,
With each leap, progress is found.
From static fields to methods bright,
We refine with each byte.
In the glow of the moon so round,
Bugs flee, no longer to confound.
🌟🐇💻

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.