Phobos icon indicating copy to clipboard operation
Phobos copied to clipboard

Insignias drawing customization. Animations on techno promotion.

Open Fryone opened this issue 2 years ago • 2 comments

[AudioVisual]
DrawInsignia.OnlyOnSelected=true
DrawInsignia.AdjustPos.Infantry=5, 2  ;position adjustment from infantry center
DrawInsignia.AdjustPos.Buildings=10, 6  ;position adjustment from building center
DrawInsignia.AdjustPos.Units=10, 6  ;position adjustment from other units center

Promote.VeteranAnimation= ;animation, played when techno is getting veteran (or elite if next is not defined)
Promote.EliteAnimation= ;animation, played when techno is getting elite
Promote.AnimationVisibility=   ;Affected House Enumeration

Summary by CodeRabbit

  • New Features
    • Introduced a promotion animation feature for units and structures, enhancing visual feedback during promotions.
    • Added an option to display insignias only on selected units, allowing for a cleaner and more focused visual experience.
  • Enhancements
    • Expanded functionality for customizable visual effects, including ElectricBolt Arcs and sound entry on unit creation.
  • Refactor
    • Standardized the approach to reading properties from INI files across various game extension modules, improving code maintainability.
  • Performance Improvements
    • Optimized code related to detonation logic, potentially enhancing game performance.
  • Documentation
    • Updated documentation to reflect new features and enhancements, including detailed guides on configuring promotion animations and insignia display options.

Fryone avatar Jan 21 '24 12:01 Fryone

Walkthrough

The recent update brings a new promotion animation feature for unit or structure promotions, offering distinct animations for different veterancy levels. It enhances control over insignia display, allowing customization for selected units. Additionally, the update standardizes the process of reading INI files across various modules, potentially improving performance and simplifying code.

Changes

Files Change Summary
CREDITS.md
docs/Whats-New.md
Added details and documentation for the promotion animation feature.
docs/Fixed-or-Improved-Logics.md
src/Ext/Rules/Body.h
Expanded options for insignia display with a new setting.
docs/New-or-Enhanced-Logics.md Introduced customization for promotion animations and visibility settings.
src/Ext/Rules/Body.cpp
src/Ext/Techno/Hooks.cpp
Implemented visual effects for promotions and control over insignia display.
YRpp Updated the subproject commit reference.
src/Ext/AnimType/Body.cpp
.../BuildingType/Body.cpp
.../BulletType/Body.cpp
.../SWType/Body.cpp
.../TechnoType/Body.cpp
.../WarheadType/Body.cpp
.../WeaponType/Body.cpp
Standardized the process of reading INI files.
src/Ext/Bullet/Hooks.DetonateLogics.cpp Simplified code and potentially improved performance.

Poem

In the realm of code, where changes gleam bright,
Rabbits dance in the glow of the digital light.
Promotions and animations, a symphony they play,
Standardizing the dance, in an elegant array.
Through lines of code, they prance and they flip,
Crafting a world with each elegant script.
In this game of updates, where features entwine,
The rabbits march on, in a dance so divine.

🐇💻🎶


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

:bangbang: IMPORTANT Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Jan 21 '24 12:01 coderabbitai[bot]

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

github-actions[bot] avatar Jan 21 '24 12:01 github-actions[bot]