google-cloud-build-slack issues

Fix issue when no GitHub token is specified

2

#32

Issue when no GitHub token specified

1

Hi @Philmod , When not specifying the `$GITHUB_TOKEN` environment variable I receive on Slack: `Error: TypeError: Cannot read property 'author' of undefined` And in the Functions logs: `TypeError: Cannot read...

sneko

TypeError: Cannot read property 'repoName' of undefined

4

The cloud function crashes with the following error: ``` TypeError: Cannot read property 'repoName' of undefined at Object.module.exports.createSlackMessage (/user_code/index.js:86:37) at module.exports.subscribe (/user_code/index.js:19:34) at /var/tmp/worker/worker.js:770:16 at /var/tmp/worker/worker.js:718:11 at _combinedTickCallback (internal/process/next_tick.js:73:7) at...

svenmueller

Fix author

10

This is implements a workaround for github owner info not being available in the github app triggered build object, but wanting to fetch the author info. Also some slight refactoring...

naseemkullah

Allow unauthenticated invocations? + and REGION issue

Hi @Philmod , When executing `setup.sh` I see: `Allow unauthenticated invocations of new function [cloud-notifier]? (y/N)?` Will it work if I keep it protected? Another point is, by taking a...

sneko

Send messages to different slack channel based on trigger

8

Hello, Although having a default slack channel to send notifications is desired, it would be nice to be able to override the channel for specific repos. Agree? And if so...

naseemkullah

Add github commit author retrieval method for github app triggers

2

Hello, Seeing that github app triggers are in the works, the current retrieval method for the github owner does not work since there is no `cloudSourceRepo` to "fetch" `githubOwner, githubRepo`...

naseemkullah

Cannot find module './config.json'

2

Hi, Any idea why i see the following error when deploying the function? ``` $ ./setup.sh Updated property [core/project]. Creating gs://-gcf-65756756756/... WARNING: Flag `--runtime` will become a required flag soon....

svenmueller