MPAndroidChart icon indicating copy to clipboard operation
MPAndroidChart copied to clipboard

fix Poolable object leak context issue

Open lbtrace opened this issue 6 years ago • 5 comments

PR Description

  • As we know ObjectPool cache some Poolable Objects, but some Poolable Object reference to View Object, and View Object reference to Context Object, And ObjectPool is static, so leak Context. For exsmple, ObjectPool.objects ---> AnimatedMoveViewJob.view ---> View.mContext ---> Context

  • For this issue, I Clear Poolable Object fields when Poolable Object is recycled. Please check patch code

  • I think lots of memory leak occurs when using MPAndroidChart, so please merge this patch.

lbtrace avatar Apr 20 '19 15:04 lbtrace

I would really appreciate this patch. Leakcanary caught the memory leak for me.

S0und avatar May 01 '19 18:05 S0und

Do you have a schedulle on when this will be in a new version?

NunoPontes avatar May 02 '19 10:05 NunoPontes

Merged this at https://github.com/SubhrajyotiSen/MPAndroidChart which will be an updated fork

SubhrajyotiSen avatar Nov 02 '20 10:11 SubhrajyotiSen

Hello, Leak Canary also detected this memory leak in our app. Any chance this PR will be merged soon?

johnsabilla avatar Apr 15 '21 22:04 johnsabilla

It's included here https://github.com/AppDevNext/AndroidChart/releases/tag/3.1.0.25

hannesa2 avatar Oct 04 '24 11:10 hannesa2