Peter Leng comments

Results 22 comments of


                                            Peter Leng

Emit metric for seconds since UNIX epoch of expiration for loaded certs

/retest

Emit metric for seconds since UNIX epoch of expiration for loaded certs

/retest

Emit metric for seconds since UNIX epoch of expiration for loaded certs

Seems like getting an unrelated error from clang-tidy. I'm not sure how to fix it but was able to get green CI from retest though takes a few tries.

Emit metric for seconds since UNIX epoch of expiration for loaded certs

/retest

Emit metric for seconds since UNIX epoch of expiration for loaded certs

clang-tidy error in CI shows the following: ``` Error while processing /source/envoy/ssl/certificate_validation_context_config.h. /build/bazel_root/base/execroot/envoy/./source/common/common/base_logger.h:7:10: error: 'spdlog/spdlog.h' file not found [clang-diagnostic-error] #include "spdlog/spdlog.h" . . . ``` I did add some code...

Emit metric for seconds since UNIX epoch of expiration for loaded certs

fyi, going on a short vacation and be back to work on this end of this month. @ggreenway

Emit metric for seconds since UNIX epoch of expiration for loaded certs

Addressed feedback. Ready for another round of review :grin:

Emit metric for seconds since UNIX epoch of expiration for loaded certs

/retest

Emit metric for seconds since UNIX epoch of expiration for loaded certs

/retest

Emit metric for seconds since UNIX epoch of expiration for loaded certs

Commenting to bring out of stale. Will work on it next week. Had some other high priority work last few weeks so wasn't able to work on it.