PerlDancer
Allow overriding of prefix in add_route. #1663
The order of the arguments in add_route was such that, whenever you called add_route from a plugin, any 'prefix' entry you submitted was ignored utterly. Rearranging the order here lets plugin authors override the prefix on their add_route calls, even with undef.
I've pushed a commit that fills in some missing bits for the test state. These warnings were occurring when a 404 was reached, and the SERVER_PORT and SERVER_NAME were not set.
Is there a reason a number of tests were commented out in t/app.t? The tests that changed to account for your patch make sense to me, but it seems like the ones that have been commented out are not related to the functionality in the branch.
Entirely possible I have missed something though :)
that was my goof. I shorted out a bunch of other tests while I was working on the failures @xsawyerx had pointed out, and flat forgot to re-enable them. Fix pushed to this branch.
Approved :+1:
@xsawyerx I'm considering your approval to still be valid as the core code remains unchanged since when you approved it.
