Dancer2 icon indicating copy to clipboard operation
Dancer2 copied to clipboard

Dancer2::Manual::Deployment does not mention using the behind_proxy configuration option

Open jasonblewis opened this issue 9 years ago • 8 comments

Setting the behind_proxy setting should be mentioned in the doco as if you are using apache to do the proxying and ssl termination, d2 will be generating http links instead of https

jasonblewis avatar May 05 '16 01:05 jasonblewis

@jasonblewis Any chance for a PR on this? I would merge it right away.

xsawyerx avatar May 26 '16 10:05 xsawyerx

Tentative PR available: https://github.com/PerlDancer/Dancer2/pull/1189

nunorc avatar Jun 14 '16 10:06 nunorc

Should be enough. Reopen if not. Thanks.

ambs avatar Jul 06 '16 13:07 ambs

Hi, it looks like this still isn't in the current Dancer2::Manual::Deployment documentation for Dancer2 (0.206000). Is it possible to re-merge this?

whosgonna avatar Jul 28 '18 20:07 whosgonna

Done, thanks for bringing it to our attention. No idea what happened there.

cromedome avatar Jul 29 '18 13:07 cromedome

Yeah it is weird. Checked for the commit hash and also for the text change in master ... not there.

racke avatar Jul 29 '18 17:07 racke

Slightly related, the config manual documentation for behind_proxy has a section for setting Apache config to use X-Forwarded-Protocol and X-Forwarded-host that don't look to be in the deployment manual in this section. I'm not using Apache mod_proxy anywhere, so I don't feel like I'd be an authoritative voice for adding the instructions, bit probably is relevant. Related note, I am using Nginx as a reverse proxy, and the example on the deployment page does include this information.

whosgonna avatar Jul 29 '18 17:07 whosgonna

@racke @whosgonna: I merged this again a little while ago.

@whosgonna: Thanks, I will leave this issue open until we resolve that. I like the suggestion.

cromedome avatar Jul 29 '18 17:07 cromedome