perl5 icon indicating copy to clipboard operation
perl5 copied to clipboard

Mark dowantarray() as deprecated

Open ilmari opened this issue 3 years ago • 1 comments

This will make uses of the also-deprecated GIMME macro emit a compile-time warning.

Note that there are 3 modules still using GIMME in core, so this should not be merged until these are merged:

  • #20138
  • pmqs/Compress-Raw-Zlib#19
  • pmqs/Compress-Raw-Bzip2#8

ilmari avatar Aug 23 '22 19:08 ilmari

This will make uses of the also-deprecated GIMME macro emit a compile-time warning.

Note that there are 3 modules still using GIMME in core, so this should not be merged until these are merged:

* [Time-HiRes: use GIMME_V instead of the deprecated GIMME #20138](https://github.com/Perl/perl5/pull/20138)

* [Use GIMME_V instead of the deprecated GIMME pmqs/Compress-Raw-Zlib#19](https://github.com/pmqs/Compress-Raw-Zlib/pull/19)

* [Use GIMME_V instead of the deprecated GIMME pmqs/Compress-Raw-Bzip2#8](https://github.com/pmqs/Compress-Raw-Bzip2/pull/8)

Looks good to me, but ... we'll need new CPAN releases of Compress-Raw-Bzip2 and -Zlib which we can then synch into blead.

jkeenan avatar Sep 08 '22 14:09 jkeenan

@ilmari, this pull request still needs review. Could you resolve the merge conflicts that have developed so that we can move the discussion forward.

Thank you very much.

jkeenan avatar Jan 17 '23 00:01 jkeenan

Conflicts resolved.

demerphq avatar Feb 07 '23 15:02 demerphq

@ilmari: Note all the patch links @jkeenan posted are applied. We should merge this once it passes CI.

demerphq avatar Feb 07 '23 15:02 demerphq

@demerphq The Compress-Raw-{Zlib,Bzip2} changes need to be released to CPAN and imported to blead before this can be merged.

ilmari avatar Feb 07 '23 17:02 ilmari

@ilmari acknowledged. Have you poked the owner to roll a release?

demerphq avatar Feb 08 '23 01:02 demerphq

@ilmari the modules have been released to CPAN by @pmqs. See https://github.com/pmqs/Compress-Raw-Zlib/pull/19 for conversation on this.

demerphq avatar Feb 09 '23 09:02 demerphq