PeriLab.jl icon indicating copy to clipboard operation
PeriLab.jl copied to clipboard

[Bug]: Gather maximum damage values for MPI

Open CWillberg opened this issue 8 months ago • 3 comments

PeriLab Version

1.4.2

Julia Version

1.11.5

MPI Version

No response

What is the expected behavior?

The simulation should write "Damage initated!" using set_multiline_postfix(iter, "Damage initated!").

What is the actual behavior?

My simulation errored calling "set_multiline_postfix(iter, "Damage initated!")" at core 2. Reason is, that iter at core > 1 has the wrong type.

Reproduction steps

use more than one core.
a multi-core test must be included.

Relevant log output


Which release of PeriLab are you seeing the problem on?

  • [ ] Julia Package
  • [ ] Linux Release
  • [ ] Docker Image

CWillberg avatar Jun 18 '25 13:06 CWillberg

Commit d5f1d17 should fix this already

JTHesse avatar Jun 18 '25 14:06 JTHesse

it does partially fix the problem. max_damage = maximum(damage[active_nodes]) is set at each core. How does core 1 knows if core 6 has a damage?

CWillberg avatar Jun 18 '25 14:06 CWillberg

#TODO gather value 😉 So yes, that is missing

JTHesse avatar Jun 18 '25 14:06 JTHesse