PiHoleBlocklist icon indicating copy to clipboard operation
PiHoleBlocklist copied to clipboard

Remove too general rule

Open DennisGaida opened this issue 3 years ago • 1 comments

This blocks all internal hostnames such as raspberrypi or myspecialserver and shouldn't be used.

I also don't understand what the actual rule is supposed to do, i.e. "connect to several garbled letter combinations". I don't think that LG TVs just connect to "goobledidock", but rather to some .com domain name?

DennisGaida avatar Aug 21 '22 08:08 DennisGaida

FWIW, this sounds a lot like Chrome's Intranet Redirect Detector.

AJCxZ0 avatar Aug 22 '22 01:08 AJCxZ0

It was made more specific with https://github.com/Perflyst/PiHoleBlocklist/commit/24d1fb411dbb43ace84096fbc0e7fdc0780447b0

Perflyst avatar Sep 24 '23 15:09 Perflyst

@Perflyst uhm this is still bad. /^[a-rt-z][a-z]{10,14}$/ still matches general hostnames such as raspberrypi. Probably also relevant is the commiter @DandelionSprout

DennisGaida avatar Oct 09 '23 11:10 DennisGaida

@Perflyst please reconsider this. The creator also tends to agree, as do I. Please see: https://github.com/Perflyst/PiHoleBlocklist/commit/24d1fb411dbb43ace84096fbc0e7fdc0780447b0#commitcomment-129547850

Technetium1 avatar Oct 09 '23 19:10 Technetium1