Add mssql creds to nxcdb
Description
As for LDAP since lap1nou's PR, MSSQL creds were not saved in database. This PR fixes that by copy pasting the code from SMB protocol and adapting it to MSSQL when needed.
Type of change
Please delete options that are not relevant.
- [X] Bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds functionality)
How Has This Been Tested?
I ran Ruff and e2e tests, got some errors which seem not related to this PR (on add-computer and empire_exec SMB modules, also NFS first test taking forever so I had to ctrl+c)
Screenshots (if appropriate):
Before :
After :
Checklist:
- [X] I have ran Ruff against my changes (via poetry:
poetry run python -m ruff check . --preview, use--fixto automatically fix what it can) - [ ] I have added or updated the tests/e2e_commands.txt file if necessary
- [X] New and existing e2e tests pass locally with my changes
- [X] My code follows the style guidelines of this project (should be covered by Ruff above)
- [ ] If reliant on third party dependencies, such as Impacket, dploot, lsassy, etc, I have linked the relevant PRs in those projects
- [X] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation (PR here: https://github.com/Pennyw0rth/NetExec-Wiki)
Nice one! Thanks for the PR, i will take a closer look at it when i find some time
Hi, sorry i kinda missed this PR when reviewing #1012, but i think this one was outdated after #727 anyway. It is implemented and merged now regardless, thanks for your work!