Add tutorial on Quantum Phase Estimation
Before submitting
Please complete the following checklist when submitting a PR:
-
[ ] Ensure that your tutorial executes correctly, and conforms to the guidelines specified in the README.
-
[ ] Add a thumbnail link to your tutorial in
beginner.rst, or if a QML implementation, inimplementations.rst. -
[ ] All QML tutorials conform to PEP8 standards. To auto format files, simply
pip install black, and then runblack -l 100 path/to/file.py.
When all the above are checked, delete everything above the dashed line and fill in the pull request template.
Title: Quantum Phase Estimation for Molecular Ground State Energies
Summary:
Relevant references:
Possible Drawbacks:
Related GitHub Issues:
Thank you for opening this pull request.
You can find the built site at this link.
Deployment Info:
- Pull Request ID:
535 - Deployment SHA:
6b0bb15e5e7879a66a3feed3bd558d94d2a2d4d1(TheDeployment SHArefers to the latest commit hash the docs were built from)
Note: It may take several minutes for updates to this pull request to be reflected on the deployed site.
Hey make sure that Catalina's comments have been resolved. I see things you haven't changed like the initial bar that appears before the authors or Jay's photo in the bios.
Hey make sure that Catalina's comments have been resolved. I see things you haven't changed like the initial bar that appears before the authors or Jay's photo in the bios.
@Exferro @davidecast
Hi Guillermo,
Sorry for not getting back to you, it has been super hectic in the last weeks.
Right now I am at a summer school but next week I will adress all the remaining points.
Davide
Il mar 20 set 2022, 18:30 Guillermo Alonso-Linaje @.***> ha scritto:
Hey make sure that Catalina's comments have been resolved. I see things you haven't changed like the initial bar that appears before the authors or Jay's photo in the bios.
@Exferro https://github.com/Exferro @davidecast https://github.com/davidecast
— Reply to this email directly, view it on GitHub https://github.com/PennyLaneAI/qml/pull/535#issuecomment-1252604205, or unsubscribe https://github.com/notifications/unsubscribe-auth/AONK5UENHUEJWZBMMSMFVFDV7HRAXANCNFSM55MWAFMQ . You are receiving this because you were mentioned.Message ID: @.***>
I can't get the demo to display, can you see it?
Hm, I can't see it too, maybe @davidecast has more info?
That is very strange 🤔 It is available here (https://qml-build-previews.pennylane.ai/pull_request_build_preview/535/demos/tutorial_qpe.html), but not sure why it is not showing up on the chemistry page
Not sure why this is happening, I only accepted some comments from Catalina and added my picture to the bio. I'll try to look a bit into it during the afternoon :/
@josh146 same problem in this other demo. It was finished but now does not display in the chemistry page 🤔
It looks like both demos are out of sync with the master branch :) If you look at the demos_*.rst files, they should be using .. gallery-item::, not .. customgalleryitem::
https://github.com/PennyLaneAI/qml/blob/master/demos_quantum-chemistry.rst
Oh thank you! That was the problem! 😍 I thought that as long as the PR didn't say that the branch was out of date, it would be the synchronization
I learned a lot from this demo! 💯 But to be production-quality, it still needs several changes:
- There's an incomplete section
- Typos and grammar, acronyms
- Some parts require more explanation. Mostly the initial QPE code, the use of QPE after VQE.
- Code needs more comments
Please do not click on resolve conversation in any of the comments. Only reviewers will do this. If you need to implement a suggestion, click on
commit suggestion. And if you've already fixed some of these locally, please don't forget to push the latest version as you do!
@Exferro @davidecast , could you work on the requested changes?
Remark again, you will have to click on commit suggestion if you accept the change :)
Hey @KetpuntoG! I know, this is long overdue, but I got buried under lots of academic/teaching obligations, I will get back to this demo when the Oxford term is over, i.e. on the week starting December 5.
Sorry for keeping postponing!
Let's try to finish this soon in January :)
@Exferro @davidecast please do not leave this
Hi @KetpuntoG!
Sorry for replying late and that we are dragging our last fixes, I will work on the remaining changes requested in the next days and then @Exferro will go on from there.
A new QPE demo with the new PL features is on the way. I close this PR as it is not expected to be merged