catalyst icon indicating copy to clipboard operation
catalyst copied to clipboard

Add Hermitian Support for Finite-Shot Measurement Statistics

Open multiphaseCFD opened this issue 2 years ago • 6 comments

Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Shortcut Stories: [sc-53754]

multiphaseCFD avatar Jan 10 '24 20:01 multiphaseCFD

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.95%. Comparing base (bd09fe1) to head (71af0cf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #451      +/-   ##
==========================================
- Coverage   99.95%   97.95%   -2.01%     
==========================================
  Files          20       71      +51     
  Lines        4439    10505    +6066     
  Branches        0      886     +886     
==========================================
+ Hits         4437    10290    +5853     
- Misses          2      170     +168     
- Partials        0       45      +45     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 11 '24 20:01 codecov[bot]

Thanks @dime10 ! Per packaging/wheels building, we should add RPATH (path\to\liblapack or scipy) to cmake. RPATH embeds information in the binary about where to find its dependent shared libraries at runtime. We've already use it to fix DSO errors for L-GPU when linking against custatevec.so.

multiphaseCFD avatar Jan 20 '24 13:01 multiphaseCFD

Thanks @dime10 ! Per packaging/wheels building, we should add RPATH (path\to\liblapack or scipy) to cmake. RPATH embeds information in the binary about where to find its dependent shared libraries at runtime. We've already use it to fix DSO errors for L-GPU when linking against custatevec.so.

The one problem I see with this is that for deployed packages (like a Catalyst wheel), the correct RPATH (on the user's system) is not known at build time.

dime10 avatar Jan 22 '24 16:01 dime10

@multiphaseCFD what's the status on this? Happy to dedicate a few cycles for review if it is ready :) Thanks!

erick-xanadu avatar May 09 '24 22:05 erick-xanadu

@multiphaseCFD Was this something we still plan on landing?

dime10 avatar Jul 12 '24 15:07 dime10

Was this something we still plan on landing?

Hey @dime10 , it's not a priority for Q3, but I'm keen to determine if we can complete it before the start of Iteration 2. If not, I will come back to it after all Q3 tasks are done. One thing I would like to bring up is that scipy doesn't support PPC systems.

multiphaseCFD avatar Jul 12 '24 15:07 multiphaseCFD