pecan icon indicating copy to clipboard operation
pecan copied to clipboard

Remove Browndog

Open Sweetdevil144 opened this issue 1 year ago • 2 comments

Description

  • Remove Browndog support from convert_input

TODO : Remove Browndog support from all instances

Motivation and Context

Review Time Estimate

  • [ ] Immediately
  • [ ] Within one week
  • [x] When possible

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x] My change requires a change to the documentation.
  • [ ] My name is in the list of CITATION.cff
  • [x] I have updated the CHANGELOG.md.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] All new and existing tests passed.

Sweetdevil144 avatar Jul 31 '24 07:07 Sweetdevil144

Only instances of Browndog remaining are below (w.r.t to *.R search)


Screenshot 2024-08-07 at 10 27 48 AM

Sweetdevil144 avatar Aug 07 '24 05:08 Sweetdevil144

Let's also remove:

  • [x] Documentation of browndog functionality in book_source/
  • [x] browndog handling steps in web/ (mostly but not all in php files)
  • [x] web config files in docker/web/config/docker.php and base/utils/tests/testthat/data/config.example.php

And not edit:

  • XML files in tests/ (I think this contradicts what I said when we talked live, but I'm now leaning toward not disturbing them)
  • scripts in inst/ folders (I think just in the benchmark package, but same goes for inst in other packages)

infotroph avatar Aug 08 '24 18:08 infotroph

@Sweetdevil144 It looks like your commit of the final dependency update got pushed to #3324 instead of here.

To fix, please:

git checkout delete-browndog
git pull # (assumes you have your local branch set up to track Sweetdevil144/delete-browndog; if not, replace this line with however you sync your local and remote branches)
git cherry-pick 0ac5b39d5
git push #(same assumption as above)

Don't worry about removing commit 0ac5b39d5 from #3324 -- we'll merge this PR first and it'll become a no-change there.

infotroph avatar Sep 03 '24 19:09 infotroph