Ic dongchen

[DongchenZ]

Description

1. Small bug fixes for the existing NEON IC_process.
2. temporally added a new function for multi-site NEON download. (will generalize it later)
3. updated existing function pft.add.spp and put it under base/db/R folder.

Motivation and Context

Review Time Estimate

• [ ] Immediately
• [ ] Within one week
• [x] When possible

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [x] My change requires a change to the documentation.
• [x] My name is in the list of CITATION.cff
• [ ] I have updated the CHANGELOG.md.
• [ ] I have updated the documentation accordingly.
• [ ] I have read the CONTRIBUTING document.
• [ ] I have added tests to cover my changes.
• [x] All new and existing tests passed.

[mdietze]

@DongchenZ this PR is building successfully now. If you could address the remaining issues I'm happy to pull in. Note that there's a few things you list as "fixed" in the review comments that haven't yet been updated.

[DongchenZ]

[DongchenZ]

Sorry for the late response, I already fixed those bugs long ago but I didn't do the PR so they will probably look the same; I apologize for that, and I already did a new PR that fixed the bugs you mentioned previously. @mdietze

[DongchenZ]

Looks like all Github checks are passed! I deleted the old file called: download_NEON_multi_site.R and replaced it with a new script called: Multi_Site_IC_process_script.R and that will help people who is working on creating IC files with multi-site settings. And I hope if you can help me review those changes! Thanks a lot! @mdietze