pecan icon indicating copy to clipboard operation
pecan copied to clipboard

Do regular tests of our download code.

Open robkooper opened this issue 3 years ago • 3 comments

Disabling the tests is not a perfect solution. We should have a new test that is run every week to make sure our download code is not broken (or to detect a site it down).

Originally posted by @robkooper in https://github.com/PecanProject/pecan/issues/2910#issuecomment-1043190827

robkooper avatar Feb 17 '22 19:02 robkooper

From slack discussion

@infotroph provided some thoughts

"You’ll use some combination of the testthat::skip_* functions. the fastest immediate option is skip_on_ci, with the caveat that I don’t know how often anyone calls the tests NOT on CI these days."

"Eventually, we could set it to, say, skip when some other environment variable we control (e.g. PECAN_RUN_DATA_DOWNLOAD_CHECKS?) is not set. Then we could skip it on most runs but sometimes kick off a longer-jobs CI that sets that variable."

particularly setting and env variable to kick off these tests. Or we could just do it based on elapsed time...

serbinsh avatar Mar 18 '22 14:03 serbinsh

Hey, can you assign me to this issue? I would like to work on this one!

PriyanshSarvehi avatar May 07 '22 10:05 PriyanshSarvehi

This issue is stale because it has been open 365 days with no activity.

github-actions[bot] avatar Jul 09 '23 00:07 github-actions[bot]