Ömercan Yazici comments

Results 33 comments of


                                            Ömercan Yazici

Hero Wavelength Sampling Bias

Carefully choosing the spectral domain is reducing the bias. [360, 760] returns around 1.05 instead of 0.9 compared to the CIE spectral domain. More investigations are needed, but it is...

Principled IOR mismatch

True, but the behavior is inconsistent in the implementation. The rough dielectric bsdf has no problem dealing with it... the principled bsdf however does. So there is a "happy accident"...

[Low Priority] Simple Interactive Preview

This also requires improved scene loading -> Should be done in advance.

CMake error on Windows for utility target

The actual error message is: ``` CMake Error at build/_deps/rv-src/plugin/CMakeLists.txt:12 (target_link_libraries): Utility target "RVPLUG" must not be used as the target of a target_link_libraries call. ```

CMake error on Windows for utility target

Here is the full cmake output (until I stop it with CTRL-C): ``` -- AnyDSL contrib directory: C:/Development/Projects/deps/anydsl/contrib -- AnyDSL remote url: https://github.com/AnyDSL -- AnyDSL default branch: master -- Found...

Allow `use` to import declarations into the current namespace, like in Rust

Is the parent scope/module visible by default or do we have to use `super` still? E.g., ```rust fn foo() = 42; mod bar { fn sup() { let v =...

Allow `use` to import declarations into the current namespace, like in Rust

Seems like it is the standard in Rust, so I would say we stick to the default. Spamming some `use super::*` everywhere is a small burden to bear :D

Set some optional dependencies to find_package(... QUIET).

I like this, but I also agree with the last point that we have to list all the "features" the runtime in the end provides. It is not really funny...

Prevent crash when `compile` fails in JIT

Yes, thats why the new commit :P

Prevent crash when `compile` fails in JIT

It does continue parsing and does not error recovery from that. `artic` produces a spill of unrelated syntax errors outputs, but it does not crash. E.g., (constructed case) ``` let...