tkVideoPlayer icon indicating copy to clipboard operation
tkVideoPlayer copied to clipboard
verified publisher icon PaulleDemon

Feat: Add Loop property

Open CodeYan01 opened this issue 2 years ago • 4 comments

Makes it easier to toggle looping, and prevents flickering that would be caused by calling TkinterVideo.play() after the "<<Ended>>" event.

Fixes #32

CodeYan01 avatar Jun 02 '23 11:06 CodeYan01

I only made it a property (with get/setter) for consistency with other functions like keep_aspect and set_resampling_method having setter functions that don't really do anything else. But having a getter too imo is important if you're gonna have a setter, so I made it a Python property for completeness

CodeYan01 avatar Jun 02 '23 12:06 CodeYan01

Hi, I am currently will look into this as soon as I am free

PaulleDemon avatar Jun 05 '23 08:06 PaulleDemon

Ok, I am looking into this. @Brandon4466 can you help me understand which part is not being Garbage collected? I will try to implement this ASAP

PaulleDemon avatar Jun 10 '23 12:06 PaulleDemon

@Brandon4466 were you suggesting changes to this PR? Because on github it shows that you are suggesting changes but I don't see anything new that you changed.

CodeYan01 avatar Jun 10 '23 18:06 CodeYan01