Encoder icon indicating copy to clipboard operation
Encoder copied to clipboard

Sanguino Interrupt define incomplete

Open mamama1 opened this issue 4 years ago • 0 comments

Hi

I would suggest to add 1284(P) support by adding " || defined(AVR_ATmega1284P) || defined(AVR_ATmega1284)" to line 59 in interrupt_pins.h.

Currently working on a project in PlatformIO with an Encoder and a 1284P and meanwhile I'm doing this via build options:

-D CORE_NUM_INTERRUPT=3
-D CORE_INT0_PIN=10
-D CORE_INT1_PIN=11
-D CORE_INT2_PIN=2

I'd do a pull request but unfortunately I'm too stupid for that. Thanks!

mamama1 avatar Dec 08 '21 21:12 mamama1

Note that the commit message isn't exactly the same as the PR description. See if it's acceptable to you.

ssilverman avatar Sep 15 '21 05:09 ssilverman