angular-websocket icon indicating copy to clipboard operation
angular-websocket copied to clipboard

Improved testability of socket code

Open VonRehberg opened this issue 9 years ago • 3 comments

I implemented automatical notification of listeners, so that the test code does not need to have access to the productive socket instance to invoke the listeners. Additionally it is now possible to fake a socket close and a message initialized by the backend.

VonRehberg avatar Jul 05 '16 09:07 VonRehberg

I was using angular-websocket and when I tried to test my service that use the lib I realized that a lot of functionality was not implemented in the mock. So I started adding them when I bumped into your pull request. I implemented my service's test cases using your mock's version and they run very well. Thanks for sharing your work.

andresgazzoli avatar Nov 17 '16 16:11 andresgazzoli

Thanks a lot for your feedback! Hope it will get merged soon :-)

VonRehberg avatar Nov 17 '16 19:11 VonRehberg

This PR is great! I hope this gets some attention and makes it into a release.

mikedaly avatar Oct 18 '17 18:10 mikedaly