Patrick Remy
Patrick Remy
Any ideas @orklah ?
It's finally done! After a lot of work and deeply digging into the taint system of psalm, I was able to fix many taint bugs since 5.x and added a...
Someone? Maybe @orklah?
Thank you so much! 😊
Would be great, if this could be reviewed, as especially without OAuth or configured captcha an open registration page is not a good idea for a private selfhosted page.
Maybe both changes are required, in my PR I am also adding massive Taint-related tests and fixing examples. Anyway, in my PR I still had issues that some taints weren't...
I now had time to test your changes and applied them to my original PR. At least for me the test you mentioned is still failing. And moreover, if I...
Even rebased and with your commit applied, the test you mentioned is failing in the CI: https://github.com/vimeo/psalm/actions/runs/9747343000/job/26899836333?pr=10206 Therefor I will revert your change from my branch again, as mentioned in...
@cgocast I think you can close this PR, as #10206 is merged and released
Maybe @TheMeier as the original contributor for the rocketchat integration can review my contribution. Unfortunately I have no idea why tests are failing, but as disclaimer I am not a...