SMAPI icon indicating copy to clipboard operation
SMAPI copied to clipboard

ModBuildConfig 4.3.0: ContentPacks IgnoreModFilePatterns attribute not working as expected

Open b-b-blueberry opened this issue 1 year ago • 0 comments

Expected: Using ItemGroup ContentPacks, including a CP project in the same solution would copy both C# and CP components to a parent folder when the C# project is built, ignoring paths and patterns given in the IgnoreModFilePatterns and IgnoreModFilePaths attributes on ContentPacks.

Issue: Solution projects included in ContentPacks will deploy all files and folders to the output folder, regardless of attributes given in the main project ContentPacks or the CP project PropertyGroup.

Reproduce:

  1. Create solution including multiple projects buildable with ModBuildConfig,
  2. Add ItemGroup ContentPacks to the main project, including any other projects,
  3. Build main project, bundling all files from included projects.

Attachments: Minimum repro solution with basic C# and CP projects
Solution.zip

Other info: Possible cause?
https://github.com/Pathoschild/SMAPI/blob/66d9e82fffb61c6cf3347c9f7278bc56b0687aae/src/SMAPI.ModBuildConfig/DeployModTask.cs#L125-L127
https://github.com/Pathoschild/SMAPI/blob/66d9e82fffb61c6cf3347c9f7278bc56b0687aae/src/SMAPI.ModBuildConfig/DeployModTask.cs#L151-L153

b-b-blueberry avatar Oct 10 '24 00:10 b-b-blueberry