PathOfBuilding icon indicating copy to clipboard operation
PathOfBuilding copied to clipboard

Physical Max Hit is "nan" when using EB, MoM and phys taken as elemental

Open Nanocube3 opened this issue 8 months ago • 1 comments

Check version

  • [x] I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

  • [x] I've checked for duplicate open and closed issues by using the search function of the issue tracker

Check for support

  • [x] I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).

What platform are you running Path of Building on?

Windows

What is the value from the calculation in-game?

not applicable

What is the value from the calculation in Path of Building?

The Phys Max Hit shows "nan" when the following steps are applied:

  • Mind over Matter and Eldritch Battery skilled
  • Percentage of physical damage is taken as an element
  • Max Life is less than a specific percentage of max ES (38% in my example)

If any of those don't apply, the Phys Max Hit value is shown correctly.

How to reproduce the issue

In the example PoB, switch Arrogance between level 4 and 5. Issue is not tied to reservation, also happens if you lower the max life to <380 via custom config (38% of max ES)

PoB for PoE1 build code

https://pobb.in/Oh4UCvgWiO4f

Screenshots

Image

Nanocube3 avatar Jun 08 '25 20:06 Nanocube3

I think this is related to #8582 (though not a duplicate, just similar) I've been looking at that other issue, and had a tentative fix, but it does not seem to solve this one. For both issues having damage taken type shift surfaces the issues (in combination with eb+mom), for example here you can have cold taken as fire and get another NaN value etc.

Good issue report! I'll see if I can figure out where this goes wrong.

HeffU avatar Jun 08 '25 21:06 HeffU

Fixed by #8590 in the next release

Wires77 avatar Jun 11 '25 04:06 Wires77