PathOfBuilding icon indicating copy to clipboard operation
PathOfBuilding copied to clipboard

Fixes minor issues with only crit ailments, and the display value for chance to apply and for dot multi

Open Regisle opened this issue 1 year ago • 4 comments

Fixes #8334.

This fixes the displayed chance to apply bleed/ignite if its only from crits, this likely needs to be fixed in a better way, as well as the displayed dot multi values, noting that it was using the correct dot multi values for the actual damage calculation, and just displaying a different "average value" in breakdowns.

This also makes it so that if all instances are from crits then it wont scale up the ailment crit chance, this might be the wrong way to do it, and it might be best to have it apply 100% chance (as all instances are always crits), but I havnt looked through the calcs properly, and it would atleast require us to fix the chance to apply calcs

Regisle avatar Oct 10 '24 02:10 Regisle

It seems like there's some problems downloading Lua for the automated tests?

chrstophr-wltrs avatar Oct 28 '24 18:10 chrstophr-wltrs

It seems like there's some problems downloading Lua for the automated tests?

luajit bin is no longer available. https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/8199

Paliak avatar Oct 28 '24 19:10 Paliak

So what needs to change in this PR and/or the pipeline?

chrstophr-wltrs avatar Oct 29 '24 16:10 chrstophr-wltrs

So what needs to change in this PR and/or the pipeline?

This isn't an issue with the pr. The pipeline needs to be updated with a different source for the binary.

I proposed to use a docker container in my pr.

Paliak avatar Oct 29 '24 17:10 Paliak