PathOfBuilding icon indicating copy to clipboard operation
PathOfBuilding copied to clipboard

"Include in Full DPS" incorrectly showing as enabled after re-import for SRS

Open vietknight opened this issue 1 year ago • 0 comments

Check version

  • [X] I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

  • [X] I've checked for duplicate open and closed issues by using the search function of the issue tracker

What platform are you running Path of Building on?

Windows

How is Path of Building expected to behave?

"Include Full DPS" should show "Full DPS" in left side panel after re-importing.

It does not work because after re-import, it looks like the checkbox was not properly cleared on display(displays as checked but is unchecked in memory) (toggling this does nothing)

How does Path of Building behave?

  • "Fulll DPS" in left side panel stops showing SRS "Full DPS" after re-importing new character
  • Toggling "Include Full DPS" does not show SRS "Full DPS"
  • Toggling "Enabled" does not show SRS "Full DPS"

Fix 1:

  • Re-Selecting the SRS skill under "socket groups" panel will reset/update "Include in Full DPS" setting (clears checkbox) after 2nd import
  • Check boxing 'include in full dps' will now properly show SRS "Full DPS" upon check/uncheck

Fix 2

  • Restart PoB

How to reproduce the issue

  1. Open Fresh PoB
  2. Select Import/Export Build
  3. Import Minion Character (Passives + tree) + (items + skills)
  4. Select 'Close'
  5. Select 'Skills'
  6. Select SRS as main skill
  7. Check 'Include in Full DPS'
  8. Full DPS will now show in left side panel at bottom
  9. Select Import/Export Build
  10. Select (Passives + tree)
  11. Select (Items + skills) <- Notice this step makes Full DPS disappear from side panel
  12. Select 'Skills'
  13. Notice 'Include in Full DPS' is still checked for SRS but no 'Full DPS' data displayed in side panel

Character build code

https://pobb.in/QDNac5iUeiVr

Screenshots

image

vietknight avatar Aug 18 '24 00:08 vietknight