PathOfBuildingCommunity
Fix impale not using enemy damage taken
Fixes #7787 .
Description of the problem being solved:
Impale damage did not respect enemy damage taken modifiers. This bug is a result of fixing impale armour application recently.
Clarify "average physical hit" in impale breakdown as "average physical hit before mitigation".
Steps taken to verify a working solution:
- Checked changes to impale dps with different "enemies take % more physical damage" modifiers and Pride/Vulnerability
- Tested with minimal example and real build
Link to a build that showcases this PR:
https://pobb.in/wFfb1O9sTa5M
Change first line in Custom Modifiers and watch dps change. 1000 Hit DPS, 100% impale, 10% more damage taken, ignore all armour.
Before screenshot:
After screenshot:
As far as I can tell, the only relevant modifiers are DamageTaken and PhysicalDamageTaken (Physical reduction and Armour works already), Other modifiers affecting impale, like reflected damage or flat subtractions seem not relevant to enemy calculations.
Impale damage is still not affected by attack damage taken, like Intimidate. Which I think is correct, but not 100%.
Also my first contribution, hope this is right.
