PathOfBuilding icon indicating copy to clipboard operation
PathOfBuilding copied to clipboard

adding build sorting by level

Open NCHitsman opened this issue 1 year ago • 1 comments

Adding Level Sorting for the BuildList.

Description of the problem being solved: Adding Level Sorting for the BuildList.

Steps taken to verify a working solution:

  • Implemented then tested
  • Tested both in and out of folders
  • Set up tests to confirm Level sorting was working unique to other sorts

Screenshots:

New Level Sorting:

image"

In folder -- image

Using the other sorting methods, showing Level sorting has unique functionality.

image

image

image

NCHitsman avatar Jul 21 '24 23:07 NCHitsman

Wasnt sure what it meant by linking to build showcasing the change, if you run the app on the branch you should be able to check it out in the Sorting dropdown on the Build List!

Let me know if Im missing anything else or did something wrong, despite being a Software Dev for years its my first time merging a fork haha

NCHitsman avatar Jul 21 '24 23:07 NCHitsman

Looks great, however I have a curveball in this build (Change .txt to .xml). It's a build from 2.6 that hasn't loaded properly in PoB for a while. Should probably fix the root cause, but in the meantime this PR shouldn't blow up when trying to sort a folder with this build in it.

Broken Build.txt

Was able to get it to work, added a few extra lines checking to make sure .level is not nil

image

In a folder -- image

NCHitsman avatar Jul 22 '24 07:07 NCHitsman