Enemy armour/pdr double-dips against impale damage

[Seikah]

Check version

• [X] I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

• [X] I've checked for duplicate open and closed issues by using the search function of the issue tracker

Check for support

• [X] I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).

What platform are you running Path of Building on?

Windows

What is the behaviour in-game?

Impale debuffs store their damage value before the defender's mitigation. This means impale is unaffected by enemy mitigation (damage taken as, less damage taken, armour/pdr) when applied. Impale damage is mitigated normally when it later deals damage.

Essentially, attacker offense applies on application, defender defense applies when impale actually hits.

This is also why regular overwhelm doesn't apply to impale, and in turn why the game needs its overwhelm-for-impale stat (Impale Damage dealt to Enemies impaled by you...) to be a debuff applied to enemies, which works for impale damage against that enemy in general, not just the player's own impales.

What is the behaviour in Path of Building?

PoB bases impale on final hit damage, which is modified by physical damage reduction. Impale damage is also modified by physical damage reduction directly. Impale is effectively mitigated twice.

That first incorrect behaviour (basing impale on final hit damage) is not limited to physical damage reduction: modifiers like less damage taken do the same thing. It's less problematic there because it doesn't cause the incorrect type of overwhelm to be used.

How to reproduce the issue

1. Add Cyclone
2. Add "100% chance to impale enemies on hit with attacks" to custom mods
3. Add "resolute technique" to custom mods
4. Set level to 10 to make enemy armour a little more dramatic.
5. Add "overwhelm 100% physical damage reduction" as a custom mod, which will increase impale dps incorrectly.
6. Add "Impale Damage dealt to Enemies Impaled by you Overwhelms 100% Physical Damage Reduction" as another custom mod, which will increase impale dps even further.

Character build code

eNqtW1tz4rgSfp78ChdV53EC5ppskd0iQC5VYcKBZOacpylhC9CObDGWTML--m1JtjEEOTZ2Hoixuj91t9St7rbp__XuUWuLA06Yf1OzLxs1C_sOc4m_uqm9vtx9var99edFf4rE-nl5GxIqR_68-NJX1xbFW0yBD9gEClZYfI-hWj_h3gb5Yo2ZP0F_s-CeuTe1b8zHNWuBfJeI-JtDEeffkIdvanMHmGsW4g723eH-fkS4RgFyBA6e5LSDULAJc2F0iSiHYQ8Rf86cX1jcByzcgFg1a0vwmyZ6nEyfZy8pmYiflgl0-tKfUrTDwVwgYXH4uKkNwDRohUfIg09AQzQEKLtzedVs9a6azVb7utOr1TOZb8OAi_MQ5huM3YSpddk1EU4DPF4usSPIFg8DIoZr5Dv76RomvqK0k5AKsqEEB5_TP3yAthtG4hcmEB1N5wltp3t53e107W6j3blqd7L5mPhcnB9ErG8p2POMWSTv48onAp_JPGWEM7-EfmlWo4qP3gbRAxHt9mW70-3Z3Su707jOVO8Db8--bMP-bDWvuo3rlnHrDUNKISbkEnCGOQ62SJBDW5i3HPMWxD9cspxiDQKMnpfaKWbIJSGfYBFgvjeN2ZsmyEdDxvebqplFOcUBRCtxwND4hGGOHQYBLs3Su8wzy2le43RPZInzUxbSJGIoKs15eozneekKA58n0AyieT7KOQtpTkqxj6rNDB_6fUBo9OoRfs8HlyZsGzfhoy9ywI3wlgl1hn-mrYps44fp3iG7ncuO3Wu27VbvumUbj7r1jhMH0Ql6J17owSnzgn5hPwVzZd5_q7XwIVgZeRvGQHxHAnwG25BR9xy2NWL8DL4JpEAPkFwNHCeEVGm3P26uspwyj_EgF3H-kMSPvpPP1V_9QMX7VAqTuThLPAMPlEnTguK8LPtJIkfOk23ouVbYjybc5VPoCWNnfQ8mniGB88X6lDTtTMtK4lyWlYSnLGvGP-QoYCbJeNpM9uVVFlNBQ419HKx28zXB1C1GHQs2RJsc8VXaOc2dy96H0xXaM2nWgib5gQI33ylUVKYt4un4bHezzaXJ8-1MDOk1MLg4b0kxDdjfsmihxdgGgcfCIOeCa-JcCsRHiy7WZtgNnXxn2S2FsjOv9CAVpYU4BkIg59eIuStcaJJCHEn9qFjn4WYDEUOufV4AeUJCgk9Sqc7Xbg7qZ9i4ufxXnqX5J9hT554gyQ_yz3LEkl8XecAXUGZPnnuKZEEnEBo8CPmqmzBhqTPDuDhQ0-Uq0BRhzup0yt5A8rVsE_Fi1JAI7ZsgRlEC7P-zy41_QJ5rgrHvQk4FrpB7jmOOU9O8EA_CJucjJJDlRtnzdxQQ5IumamFxjAJn_QRLf4coXUAkuKml78pvR4x2vLb9uurTySso8FkgLPwu_01RIHZx40wRqjuAwwXxVYEOYYfSmjVfs7eBu5VavDBGedJtQ5sN9t0DjJcAYwvFQcSRQigd5RfLQ1zACaV3JZdCp7p8j640o-UzEEAmq1etllRR1mMo2A0OCX0CckEtj1PNxmY76iNqJDntl_7r7EldfFkLseF_1Otvb2-XGyTWbInf4dC5dJhX3wATCPyV_yKUfpWw9QH83a4G6k8B1WOkvu4v8rr-Jn0xICCzXsu6VFRZXVpCXnxjAnM5Jm_GX_pzORW3OCzEPfb47Q78504mCUcdj8iUknqOhd4MaZ6bmghCLFd_iUIq7_83RJTIlW2k7z7pLq3PAi-pmwAKVlaGeY34sttI0w-envTIgIoITE4XL7Nezkggi7jxEkc3VQt2sJd6iKjDldzEd2joQu0QhZZoFSlaSMlk01km_W6s0RFOMs2XPkgTEd9TtkC0GbNErWgoTa0V9uQ2mGCBXHCr-qMAFepSj7qCg6vhzqGqp7zVHiPpk3tqKxzc-Z2ya3Qtx0faxLUDiexYoiOdHBb6ehF95EUOEk8Q7SctXrSXIiur_aR3jLxUJlUUj_4mFArrpuYR7vxchMul7HWDAiJQDfzx3d14-PL4fRwFmzSLUvKnH3oL2czV__dHwhyr1Mfi4YLry5vad4LflCAjMCyhXKpEKdpwnIQBtSUiySnwZaApKqht4874aaw9gRlp_I4DiForyJmdgGCjXMn4J0LpCWU-LYOzCU02nc1AOmUbQszT-b7BUqq_b0aRLXejOnIwg1c3dE3M0egnlhAyKMBGJUviyHMte8llCNFUGXZJGhPG9Y7yTTOG6uKbAPSgmVl34k3c0WiGVdVTAKNV9aiZfYQdZNRdD5qZkxKS-WAmE0pClYH0jflqk4PTDAiVuaFxZccUJyRmwGexxkF0tJuQJhCjYpJMxwnIIhRmN05RZNhKdbUMFpJjZlbdtjHoIMcyItFBI8Ng0DSNGUo3AIyBLItV1wlG-0VVR8YSROW1wfx6NMMIcYfBoH80nOEkKv4Otoy4uvI0uMsRWVbAgKytPIwqp8vDHNfX5RHvIPH9ZVzvaNTM_iqITGhOoOjEJReIdKpyCNK3yiHMjhOJPe8sO4VISrqTzPFoluNHld7ZCLoePZtdlctnc6vwDcksBg0y43dCk7G9ReiPwBgiY2vnhFJinY4De-0KYemT7KSmhRG1f0aPZrJcWJN8AgRH8UNGspcPKWn5PGBE5VsHjJYD_PAIqpSeTHDkuyPZsC6pqOx3hxsAiyV7PpWt75f0GLVfj-so1bSQlU3UUZmLQNaj_zDm_V-Ve_IqKqBbUdEMOe6IgKkDtUXieSTh_-JuUF_VnFEFL6_jAj7kWD9n_oHRhvnqtiyFdX2mCY1EhxU3ZVCCA8d08Tp7kkLrwk7zWLLoFroQbsT1pYnlFlNhDRY7zhG1dIvDahbgj6c8xugUx2hWgGFb8ze0OQbqVqBQtwKFimDcMvCZY4BWAYAHDBHvw9qW3RtnmeHUmnQqWBO7Aox2QYNUtSercLIiGCqFKmT1kzuwWXL_tAqLXGSB7inbYl5mm5z2mm5hhMJq2qXVLLK2Ay-kWFSwBVsVhMVWadXbhc1dZB_PIEM7x1914CusXFkX7RQ2RvljpVkaobwM7bKGa1cV21uFJHF3lu6sVB-3OlWd1nY1GjXLLlHhDKp0aOlWo3mntCCtohHLLmtsu4LYXplPdapZh27J_KV8NlI2g6rIFVtVhYbKgM4pLc6zRVV7sqKlONtHSu6kyk6HZgWBogoMuyqFKotaH4H69ajVo3pRqlekHu4zf0lWHx7VOyEXzJswl-8f7dfl8-m3NRz4lt1o_MfaRO8uWq5qdVlB_PbiRV0_67V0D8xyZWvQEswa-9gjEJn0sGstdtaOhdZzjMs1cPxSZMyfvBZ5cRFgzmgosCWws_bJ7xBfKBZHPcGVcxA9NY6mAgutibDeiFhbSD0h5xf7l6ccvGbUxUGktWTaRb-Ai19P6KVfVj5Fn_5BW8zUMbJ4yc_Z5E-gMNhsrh7byzc15pguU-9FdD6fN36TIeZpmWXlZEXo81J17WFK9ejh-BUMw0xx8Eq062XTRy-zMkpnyE-L1_vElMlzvJih2bnO5jh8fzalUS9uukb7u18__kHpv7Pesfw=

Screenshots

[Seikah]

Whoops, looks like the person I was talking to was proactive enough to file a report of their own, and I hadn't noticed. Apologies!