Impale damage is calculated from the hit damage after mitigations, not before

[KaruSmuuti]

Check version

• [X] I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

• [X] I've checked for duplicate open and closed issues by using the search function of the issue tracker

Check for support

• [X] I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).

What platform are you running Path of Building on?

Windows

What is the value from the calculation in-game?

If i deal 1000 physical damage with a hit, i have 100% chance to impale and 0% increased impale effect with 5 impales on an enemy with 50% physical damage reduction, the stored impale hit should be 500 damage (50% of the unmitigated 1000 hit) and then reduced once by the 50% physical damage reduction on the enemy, dealing 1000 x 0.5 + 500 x 0.5 = 750 physical damage.

What is the value from the calculation in Path of Building?

In PoB, the impale is calculated from the 500 damage (after mitigations), making the stored impale 250 damage, which then gets reduced again by the 50% damage reduction on the enemy. That adds up to 1000 x 0.5 + 250 x 0.5 = 625 physical damage. (Both overwhelm mods, the normal one and the one specifically for impales technically work correctly, but since the impale stored damage is calculated after mitigations, the normal one also affects final impale damage on an enemy with physical damage reduction, when it shouldn't.)

How to reproduce the issue

I set up a sweep skill with ~1k average damage and 1.00 attack rate in PoB using custom modifiers, giving it 100% chance to impale. Then when i tested both overwhelm mods ("Overwhelm X% Physical Damage Reduction" and "Impale Damage dealt to Enemies Impaled by you Overwhelms X% Physical Damage Reduction") the normal one affected the ipale dps, when it shouldn't.

Character build code

https://pobb.in/KBIVH-a04Pk1

Screenshots

• No overwhelm, 0% enemy pdr:

• No overwhelm, 50% enemy pdr: (should be 1000(hit before enemy pdr) x 0.5(impale multi) x 0.5(enemy pdr) = 250 impale dmg)

• 100% normal overwhelm (only), 50% enemy pdr: (should be 1000(hit before enemy pdr) x 0.5(impale multi) x 0.5(enemy pdr) = 250 impale dmg)

• 100% impale overwhelm (only), 50% enemy pdr: (should be 1000(hit before enemy pdr) x 0.5(impale multi) x 1.0(enemy pdr) = 500 impale dmg)

• 100% normal overwhelm + 100% impale overwhelm, 50% enemy pdr: