PathOfBuildingCommunity
Adorned rounding error for jewels with same stats on explicit and implicit mods
Check version
- [X] I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- [X] I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
- [X] I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the value from the calculation in-game?
Game calculates stats on the jewel with adorned with both mods from implicits and explicits together, which provides more breakpoints if you have the same mods.
Here is my jewel with 144% adorned:
And here is the same jewel with 149% adorned:
as you can see the 149% has 1 more int, which is only possible if you add explicit and implicit together and only then multiply with adorned (16 * 2.49 = 39.84, 5 * 2.49 = 12.45, 39 + 12 = 51. (16 + 5) * 2.49 = 52.29)
What is the value from the calculation in Path of Building?
PoB calculates this values separately. That can be seen in calculations:
And if you try changing adorned it also won't show any difference:
How to reproduce the issue
Use synth jewel with the same stats in implicit and explicit and find adorned breakpoints
Character build code
https://pobb.in/TNpXyz96x5QI
Screenshots
No response
Seems like this is the same problem just for the Widowhail: https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6879. I will create pr based on it.
The patch was merged and will most likely be included in next release. This should be good to close.
This is still a problem in the latest build: 2.49.3
The 150% adorned and the 149% one both have the same "attack rate" of 3.33 (I am assuming this is because the implict mod is the same as the explict mod.)
Here is a test pob: https://pobb.in/r4OFZwVfI-y0
You can also see in the skill section where the attack speeds are calculated these 3 mods are not separated - this pic should have 3 lines, not 2:
